Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new application-level setting to override the default extension restrictions in the Sessions/Agents window, allowing specific extensions to be enabled there even if they would normally be disabled, and updates the extension enablement logic + tests accordingly.
Changes:
- Introduces
extensions.supportSessionsWindowand wires it intoExtensionManifestPropertiesService.canExecuteOnSessionsWindow(...)as a user-configured override. - Registers the new setting in the configuration registry (schema + snippet).
- Adds/updates tests covering both the manifest property behavior and the enablement-state behavior in a sessions window.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts | Adds a new test suite validating sessions window execution eligibility and config overrides. |
| src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts | Adds the new config key + cached lookup and consults it in canExecuteOnSessionsWindow. |
| src/vs/workbench/services/extensionManagement/test/browser/extensionEnablementService.test.ts | Updates test wiring to use the shared configuration service and adds a sessions-window override enablement test. |
| src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts | Registers extensions.supportSessionsWindow in the configuration registry. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
roblourens
previously approved these changes
May 6, 2026
Contributor
Screenshot ChangesBase: Errored (20)Fixtures that failed to render — no screenshot was produced.
|
dmitrivMS
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a configuration option that allows extensions to be enabled in the sessions window, even if they would typically be disabled. This includes updates to the extension manifest properties and tests to verify the new behavior.