Skip to content

Label selected connection deletion accurately - #932

Merged
Tomasz Naumowicz (tnaum-ms) merged 3 commits into
mainfrom
dev/tnaum/delete-connections
Sep 18, 2026
Merged

Tomasz Naumowicz (tnaum-ms) merged 3 commits into
mainfrom
dev/tnaum/delete-connections

Conversation

@tnaum-ms

Copy link
Copy Markdown
Collaborator

What changed

  • Keeps Delete Connection... for a single selected connection.
  • Shows Delete Selected Connections... for a connection multi-selection.
  • Routes both command IDs to the existing bulk-capable removeConnection handler.
  • Keeps both commands unavailable on the Local Quick Start managed-instance row and hidden from the command palette.

Why

The existing deletion handler already processes all selected connections, but its context-menu title remained singular during multi-selection. Separate static command aliases make the operation's scope explicit without duplicating deletion behavior.

Scope

This PR changes only command contributions, registration, and manifest coverage. It does not change deletion, confirmation, resource-conflict, telemetry, or partial-failure behavior.

Validation

  • npm run build
  • npx jest --no-coverage src/commands/removeConnection/removeConnection.packageJson.test.ts src/commands/localQuickStart/contributions.test.ts (2 suites, 31 tests)

Split from #930 so dedicated index copy/paste remains focused.

@tnaum-ms Tomasz Naumowicz (tnaum-ms) added this to the 0.11.0 milestone Sep 18, 2026
@tnaum-ms

Copy link
Copy Markdown
Collaborator Author

Copilot please run full PR checks (contributing md). fix minor issues on your own. report others here on the PR as comments.

Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Copilot please run full PR checks (contributing md). fix minor issues on your own. report others here on the PR as comments.

Fixed the CI Prettier failure in 6d295ee. Full Jest (238 suites/3,687 tests), build, package, and CodeQL pass. Local lint remains blocked by 40 unrelated unsafe-type errors in src/documentdb/shell/ShellCompletionProvider.ts; CI lint passed. Hand-over remains blocked by CONTRIBUTING.md §6: no committed iteration AI-review record exists, and the automated review runner is unavailable because its configured model is missing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Code Quality Checks

Check Status How to fix
Localization (l10n) ✅ Passed
ESLint ✅ Passed
Prettier formatting ✅ Passed

This comment is updated automatically on each push.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Report

Metric Base (main) PR Delta
VSIX (vscode-documentdb-0.10.2.vsix) 9.37 MB 9.37 MB ⬇️ -0 KB (-0.0%)
Webview bundle (views.js) 6.10 MB 6.10 MB ✅ 0 KB (0.0%)

Download artifact · updated automatically on each push.

@tnaum-ms
Tomasz Naumowicz (tnaum-ms) merged commit dfae63b into main Sep 18, 2026
8 checks passed
@tnaum-ms
Tomasz Naumowicz (tnaum-ms) deleted the dev/tnaum/delete-connections branch September 18, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants