log tree: fix icons for NES parent nodes in the tree #2882
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where NES parent nodes in the log tree were not displaying the correct icons. The changes ensure that when a main entry is promoted to a parent node, its icon is properly preserved, and when filtering creates a new ChatPromptItem via withFilteredChildren, the icon is correctly copied over.
Changes:
- Simplified icon assignment in
promoteMainEntry()to directly use the child's iconPath - Enhanced
withFilteredChildren()to preserve the parent node's id, iconPath, and command when mainEntryId is set
Tyriar
requested changes
Jan 15, 2026
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.