Git - ensure repository state is up to date when committing changes #2878
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the getRepository method in IGitCommitMessageService to be asynchronous and ensures the repository state is refreshed by calling repository.status() before returning. This ensures that callers receive up-to-date repository state information when committing changes.
Changes:
- Changed
getRepositorymethod signature from synchronous to async in the interface and implementations - Added
await repository.status()call inGitCommitMessageServiceImpl.getRepository()to refresh repository state - Updated all call sites to use
awaitwhen callinggetRepository()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/platform/git/common/gitCommitMessageService.ts | Updated interface and NoopGitCommitMessageService to make getRepository async |
| src/extension/prompt/vscode-node/gitCommitMessageServiceImpl.ts | Implemented async getRepository with repository state refresh via status() call |
| src/extension/conversation/vscode-node/conversationFeature.ts | Updated two call sites to use await when calling getRepository() |
| src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts | Updated call site to use await when calling getRepository() |
Tyriar
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.