Fix downlevel async super in default parameters#4104
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix super.m() behavior in downleveled async functions
Fix downlevel async May 30, 2026
super in default parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downlevel async emit could leave
super.m()inside the inner generator function when used in a default parameter. That produced invalid JavaScript becausesuperis not legal in the generatedfunction*.Transform fix
superaccesses before transforming non-simple async parameter lists.supersubstitution to inner generator parameters as well as the body.Regression coverage
These now downlevel default initializers to
_super.m.call(this)inside the generatedfunction*.