Skip to content

cli: show environment status after login#2793

Merged
heyitsaamir merged 2 commits intomainfrom
feat/login-show-status
Apr 28, 2026
Merged

cli: show environment status after login#2793
heyitsaamir merged 2 commits intomainfrom
feat/login-show-status

Conversation

@heyitsaamir
Copy link
Copy Markdown
Collaborator

@heyitsaamir heyitsaamir commented Apr 27, 2026

Summary

  • After teams login succeeds, automatically runs the same sideloading + Azure CLI checks that teams status shows
  • Extracted environment check logic from status.ts into a shared checkAndDisplayEnvironment() function used by both commands
  • Spinners auto-mute in non-interactive terminals, falls back to plain logger.info output

Test plan

  • teams login (interactive) — shows sideloading + Azure CLI status with spinners after login
  • TEAMS_NO_INTERACTIVE=1 teams login — shows same info without spinners
  • teams status — unchanged behavior
  • teams status --json — JSON output unchanged
  • npm run test — all tests pass

After a successful login, automatically display sideloading and Azure CLI
status so users get immediate feedback without needing to run `teams status`.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 27, 2026 21:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a post-login “environment status” display by reusing the same sideloading (TDP) + Azure CLI checks currently shown by teams status, improving immediate feedback after successful authentication.

Changes:

  • Extracted TDP sideloading + Azure CLI checks into checkAndDisplayEnvironment() in status.ts.
  • Invoked checkAndDisplayEnvironment() automatically after teams login completes.
  • Suppressed spinner rendering in non-interactive mode, falling back to plain logger.info output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/cli/src/commands/status.ts Extracts environment check + display logic into a shared helper used by status and other flows.
packages/cli/src/commands/auth/login.ts Runs environment checks after login and wires in the shared helper.

Comment thread packages/cli/src/commands/auth/login.ts
Comment thread packages/cli/src/commands/auth/login.ts Outdated
Avoids coupling login command to status command module.

Co-Authored-By: Claude <noreply@anthropic.com>
@heyitsaamir heyitsaamir merged commit c994b25 into main Apr 28, 2026
3 checks passed
@heyitsaamir heyitsaamir deleted the feat/login-show-status branch April 28, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants