Skip to content

Fix ScrollView keyboard scroll drift on long key press#15988

Merged
iamAbhi-916 merged 2 commits intomicrosoft:mainfrom
iamAbhi-916:scrollview-keyboard-drift
Apr 15, 2026
Merged

Fix ScrollView keyboard scroll drift on long key press#15988
iamAbhi-916 merged 2 commits intomicrosoft:mainfrom
iamAbhi-916:scrollview-keyboard-drift

Conversation

@iamAbhi-916
Copy link
Copy Markdown
Contributor

@iamAbhi-916 iamAbhi-916 commented Apr 14, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

When a user long-presses arrow keys (Left/Right/Up/Down) on a focused ScrollView, the scroll continues drifting after the key is released. This happens because the animated ScrollBy path accumulates offsets onto m_targetPosition during rapid key-repeat events, building up a long-running animation that overshoots. Native WinUI ScrollViewer does not exhibit this behavior.

Resolves [Add Relevant Issue Here]

What

Changed arrow key scroll handling in [ScrollViewComponentView::OnKeyDown] to use [animate=false instead of [animate=true] for Up/Down/Left/Right keys.

Screenshots

Before

scroll_view_before_fix.mp4

After

scroll_view_after_fix.mp4

Testing

Locally tested

Changelog

Should this change be included in the release notes: _indicate yes

Add a brief summary of the change to use in the release notes for the next release.
Fix ScrollView keyboard scroll drift on long key press

@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner April 14, 2026 09:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Performance Test Results

Branch: scrollview-keyboard-drift
Commit: f405e236
Time: 2026-04-14T13:46:27.109Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 5.20ms 5.00ms ±2.10ms 1 +0.0%
SectionList unmount 0.40ms 0.00ms ±0.52ms 0 +0.0%
SectionList rerender 12.00ms 11.00ms ±3.16ms 2 +4.8%
SectionList with-3-sections-15-items 5.30ms 5.00ms ±0.82ms 1 -9.1%
SectionList with-5-sections-50-items 5.70ms 5.00ms ±1.34ms 1 -16.7%
SectionList with-10-sections-200-items 5.40ms 5.00ms ±1.58ms 1 -9.1%
SectionList with-20-sections-200-items 5.30ms 5.00ms ±2.79ms 1 +0.0%
SectionList with-section-separator 2.10ms 2.00ms ±0.74ms 1 +0.0%
SectionList with-item-separator 3.20ms 3.00ms ±1.62ms 1 +50.0%
SectionList with-header-footer 1.90ms 2.00ms ±0.57ms 1 +0.0%
SectionList with-section-footer 2.30ms 2.00ms ±0.67ms 1 +0.0%
SectionList with-sticky-section-headers 2.30ms 1.50ms ±2.75ms 1 -25.0%
SectionList with-empty-list 0.40ms 0.00ms ±0.52ms 1 -100.0%
SectionList with-50-sections-1000-items 1.40ms 1.00ms ±0.52ms 1 -50.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 3.30ms 3.00ms ±0.82ms 1 -25.0%
FlatList unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
FlatList rerender 10.30ms 11.00ms ±1.77ms 2 +22.2%
FlatList with-10-items 4.40ms 4.00ms ±0.84ms 1 +0.0%
FlatList with-100-items 5.10ms 5.00ms ±1.52ms 1 +0.0%
FlatList with-500-items 4.40ms 4.00ms ±1.07ms 1 +0.0%
FlatList with-1000-items 5.10ms 5.00ms ±0.88ms 1 +25.0%
FlatList horizontal 4.10ms 4.00ms ±1.10ms 1 -20.0%
FlatList with-separator 1.70ms 2.00ms ±0.67ms 1 +0.0%
FlatList with-header-footer 1.40ms 1.00ms ±0.52ms 1 -50.0%
FlatList with-empty-list 0.50ms 0.50ms ±0.53ms 1 +0.0%
FlatList with-get-item-layout 1.70ms 2.00ms ±0.48ms 1 +100.0%
FlatList inverted 1.90ms 1.00ms ±1.85ms 1 -33.3%
FlatList with-num-columns 2.50ms 2.50ms ±0.53ms 1 -16.7%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 0.90ms 1.00ms ±0.57ms 1 +0.0%
TouchableOpacity unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TouchableOpacity rerender 1.50ms 1.50ms ±0.53ms 2 +50.0%
TouchableOpacity custom-active-opacity 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity disabled 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-all-handlers 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-hit-slop 1.20ms 1.00ms ±0.63ms 1 +0.0%
TouchableOpacity with-delay 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableOpacity nested 1.40ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity multiple-10 5.67ms 5.00ms ±2.50ms 1 -16.7%
TouchableOpacity multiple-50 27.87ms 27.00ms ±4.63ms 1 -6.9%
TouchableOpacity multiple-100 54.67ms 45.00ms ±24.70ms 1 -10.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 0.90ms 1.00ms ±0.32ms 2 +0.0%
ScrollView children-20 3.20ms 3.00ms ±1.70ms 1 -25.0%
ScrollView children-100 16.07ms 16.00ms ±3.49ms 1 +0.0%
ScrollView horizontal 2.80ms 3.00ms ±0.42ms 1 -25.0%
ScrollView sticky-headers 2.60ms 3.00ms ±0.84ms 1 +0.0%
ScrollView scroll-indicators 1.10ms 1.00ms ±1.45ms 1 +0.0%
ScrollView nested 1.50ms 1.50ms ±0.53ms 1 +50.0%
ScrollView content-container-style 0.80ms 1.00ms ±0.42ms 1 +0.0%
ScrollView children-500 21.73ms 22.00ms ±5.05ms 1 +15.8%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.50ms 0.50ms ±0.53ms 1 +0.0%
TouchableHighlight unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableHighlight rerender 0.60ms 1.00ms ±0.52ms 2 +0.0%
TouchableHighlight custom-underlay-color 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight custom-active-opacity 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight disabled 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight with-all-handlers 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight with-hit-slop 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight nested-touchables 0.70ms 1.00ms ±0.48ms 1 +0.0%
TouchableHighlight multiple-touchables-10 2.70ms 2.50ms ±0.82ms 1 -16.7%
TouchableHighlight multiple-touchables-50 13.60ms 13.00ms ±2.76ms 1 +4.0%
TouchableHighlight multiple-touchables-100 31.30ms 30.50ms ±7.99ms 1 +35.6%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Pressable unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Pressable rerender 0.40ms 0.00ms ±0.52ms 2 -100.0%
Pressable with-all-handlers 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Pressable with-style-function 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable disabled 1.10ms 0.50ms ±2.13ms 1 +Infinity%
Pressable with-hit-slop 0.20ms 0.00ms ±0.42ms 1 +0.0%
Pressable nested 0.50ms 0.50ms ±0.53ms 1 -50.0%
Pressable multiple-10 2.60ms 3.00ms ±0.51ms 1 +0.0%
Pressable multiple-50 15.40ms 15.00ms ±3.31ms 1 +7.1%
Pressable multiple-100 16.20ms 14.00ms ±9.53ms 1 +16.7%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Modal rerender 0.50ms 0.50ms ±0.53ms 2 +Infinity%
Modal slide-animation 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal fade-animation 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Modal transparent 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Modal with-callbacks 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal rich-content 1.40ms 1.00ms ±0.52ms 1 -50.0%
Modal with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
Image with-resize-mode 0.30ms 0.00ms ±0.48ms 1 +0.0%
Image with-border-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
Image with-tint-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-blur-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image multiple-10 1.07ms 1.00ms ±1.16ms 1 +0.0%
Image multiple-50 4.00ms 4.00ms ±1.36ms 1 +33.3%
Image multiple-100 8.27ms 7.00ms ±3.06ms 1 -12.5%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
ActivityIndicator unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ActivityIndicator rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
ActivityIndicator size-large 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator size-small 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator not-animating 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-accessibility 0.30ms 0.00ms ±0.48ms 1 +0.0%
ActivityIndicator multiple-10 0.93ms 1.00ms ±0.26ms 1 +0.0%
ActivityIndicator multiple-50 3.40ms 3.00ms ±0.74ms 1 -25.0%
ActivityIndicator multiple-100 8.13ms 7.00ms ±2.26ms 1 +0.0%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Switch rerender 0.10ms 0.00ms ±0.32ms 2 -100.0%
Switch value-true 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch disabled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch custom-colors 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch on-value-change 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch multiple-10 1.67ms 1.00ms ±1.29ms 1 -50.0%
Switch multiple-50 9.53ms 9.00ms ±3.25ms 1 +0.0%
Switch multiple-100 17.93ms 18.00ms ±4.48ms 1 +12.5%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.50ms 0.50ms ±0.53ms 1 -50.0%
Button unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Button rerender 1.00ms 1.00ms ±0.47ms 2 +0.0%
Button disabled 0.70ms 1.00ms ±0.48ms 1 +0.0%
Button with-color 0.40ms 0.00ms ±0.52ms 1 -100.0%
Button with-accessibility 0.50ms 0.50ms ±0.53ms 1 -50.0%
Button multiple-10 6.60ms 6.00ms ±1.80ms 1 +0.0%
Button multiple-50 20.93ms 22.00ms ±8.30ms 1 -18.5%
Button multiple-100 21.47ms 14.00ms ±18.60ms 1 -26.3%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TextInput rerender 0.40ms 0.00ms ±0.52ms 2 +0.0%
TextInput multiline 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput with-value 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput styled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TextInput multiple-100 7.33ms 6.00ms ±2.02ms 1 -14.3%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
View unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
View rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
View nested-50 3.20ms 3.00ms ±0.77ms 1 +0.0%
View nested-100 7.73ms 7.00ms ±1.62ms 1 +0.0%
View shadow 0.10ms 0.00ms ±0.32ms 1 +0.0%
View border-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
View nested-500 18.33ms 12.00ms ±13.39ms 1 +20.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Text rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
Text long-1000 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text nested 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text styled 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text multiple-100 8.47ms 9.00ms ±1.64ms 1 +28.6%

SectionList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
SectionList native mount 5.34ms 5.14ms ±1.00ms 1 -21.0%

FlatList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
FlatList native mount 4.73ms 4.35ms ±0.83ms 1 -52.9%

TouchableHighlight.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight native mount 1.58ms 1.56ms ±0.13ms 1 -25.2%

TouchableOpacity.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity native mount 2.23ms 1.95ms ±0.79ms 1 -37.9%

Pressable.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Pressable native mount 1.67ms 1.64ms ±0.14ms 1 -34.8%

ScrollView.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ScrollView native mount 3.21ms 3.13ms ±0.27ms 1 -22.8%

ActivityIndicator.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator native mount 1.60ms 1.58ms ±0.20ms 1 -36.3%

TextInput.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TextInput native mount 3.56ms 3.07ms ±1.21ms 1 -24.9%

Switch.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Switch native mount 1.60ms 1.55ms ±0.19ms 1 -10.5%

Button.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Button native mount 2.44ms 2.26ms ±0.46ms 1 -13.1%

Modal.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Modal native mount 1.23ms 1.18ms ±0.18ms 1 -3.2%

Image.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Image native mount 1.85ms 1.85ms ±0.15ms 1 -18.2%

View.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
View native mount 1.48ms 1.28ms ±0.63ms 1 -10.3%

Text.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Text native mount 1.61ms 1.60ms ±0.16ms 1 -8.2%

@iamAbhi-916 iamAbhi-916 merged commit 8cb638a into microsoft:main Apr 15, 2026
32 of 33 checks passed
@iamAbhi-916 iamAbhi-916 deleted the scrollview-keyboard-drift branch April 15, 2026 05:14
github-actions bot pushed a commit that referenced this pull request Apr 15, 2026
* Fix ScrollView keyboard scroll drift on long key press

* Change files
github-actions bot pushed a commit that referenced this pull request Apr 15, 2026
* Fix ScrollView keyboard scroll drift on long key press

* Change files
github-actions bot pushed a commit that referenced this pull request Apr 15, 2026
* Fix ScrollView keyboard scroll drift on long key press

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants