ci: disable npm cache to ensure build consistency #2660
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: Android
34 tasks
acoates-ms
reviewed
Feb 3, 2026
| </PropertyGroup> | ||
| <PropertyGroup Label="ReactNativeWindowsProps"> | ||
| <ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir> | ||
| <ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir> |
Contributor
There was a problem hiding this comment.
My understanding is that SolutionDir isn't a great thing to rely on, because its possible to attempt to build the project without building the solution, in which case the SolutionDir wouldnt be set. (I dont know off hand how to trigger such a build).
But if this fixes something I'm ok with it, since I think its somewhat of an edge case.
Member
Author
There was a problem hiding this comment.
On second thought, I was thinking of potential hoisting issues but that should be fine in this case because we create a copy of it in a known place. I'll revert this.
acoates-ms
approved these changes
Feb 3, 2026
tido64
changed the title
react-native-windows path can be found
JasonVMo
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure
react-native-windowspath can be foundPlatforms affected
Test plan
CI should pass