Skip to content

fix(ui): Wait with polling if test is still scheduled #38656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 2 commits into from
Jan 21, 2026
Merged

fix(ui): Wait with polling if test is still scheduled #38656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c0aec
fix(ui): Wait with polling if test is still scheduled
cpAdm Dec 30, 2025
c1ce6e4
test(ui-mode): Source should keep showing when test is pending
cpAdm Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/trace-viewer/src/ui/uiModeTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const TraceView: React.FC<{
clearTimeout(pollTimer.current);

const result = item.testCase?.results[0];
if (!result) {
if (!result || item.treeItem?.status === 'scheduled') {
Comment thread
cpAdm marked this conversation as resolved.
setModel(undefined);
return;
}
Expand Down
19 changes: 19 additions & 0 deletions tests/playwright-test/ui-mode-test-source.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,22 @@ test('should load error (dupe tests) indicator on sources', async ({ runUITest }
Error: duplicate test title "first", first declared in a.test.ts:3
`);
});

test('should keep showing source when test is pending', async ({ runUITest }, testInfo) => {
const { page } = await runUITest({
'a.test.ts': `
import { test } from '@playwright/test';
test('zero', () => {});
test('first', async () => {
await new Promise(f => setTimeout(f, ${testInfo.timeout}));
});
test('second', () => {});
`,
});

await page.getByTitle('Run all').click();
await page.getByTestId('test-tree').getByText('second').click();
await expect(page.getByTestId('status-line')).toHaveText('Running 1/3 passed (33%)');
await expect(page.getByTestId('source-code').locator('.source-tab-file-name')).toHaveText('a.test.ts');
await expect(page.locator('.CodeMirror .source-line-running')).toHaveText(`7 test('second', () => {});`);
});
Loading