-
Notifications
You must be signed in to change notification settings - Fork 12
fix: Add traits module to reexport ThreadAware trait separately from derive macro #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 89 89
Lines 6217 6217
=======================================
Hits 6217 6217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Darksecond <[email protected]>
Co-authored-by: Darksecond <[email protected]>
Co-authored-by: Darksecond <[email protected]>
Co-authored-by: Darksecond <[email protected]>
| //! feature is enabled). | ||
| #[doc(inline)] | ||
| pub use crate::core::ThreadAware; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not expose the trait directly from the core module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name traits was suggested for the module name, I can for sure just expose it from core.
Plan to (re-)export ThreadAware trait in thread_aware crate
traitsmodule insrc/traits.rsThreadAwaretrait from thetraitsmoduletraitsmodule tolib.rsas a public module#[doc(inline)]attribute to the trait reexportthread_aware::traits::ThreadAwareOriginal prompt
ThreadAwaretrait inthread_awarecrate #179💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.