Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

Plan to (re-)export ThreadAware trait in thread_aware crate

  • Create a new traits module in src/traits.rs
  • Reexport the ThreadAware trait from the traits module
  • Add the traits module to lib.rs as a public module
  • Add #[doc(inline)] attribute to the trait reexport
  • Add comprehensive documentation explaining the dual export
  • Simplify documentation by removing Usage section
  • Run tests to ensure no regressions
  • Verify the trait can be imported from thread_aware::traits::ThreadAware
Original prompt

This section details on the original issue you should resolve

<issue_title>(re-)export ThreadAware trait in thread_aware crate</issue_title>
<issue_description>We need to (re-)export the ThreadAware trait from a module separate from the reexport in lib.rs so we can reexport it elsewhere without also reexporting the ThreadAware derive macro.

To do this we will make a traits module and reexport the trait from there.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (fa3a6db) to head (73c8b73).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          89       89           
  Lines        6217     6217           
=======================================
  Hits         6217     6217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Darksecond Darksecond changed the title [WIP] Reexport ThreadAware trait in thread_aware crate [WIP] fix: Reexport ThreadAware trait in thread_aware crate Jan 5, 2026
Copilot AI changed the title [WIP] fix: Reexport ThreadAware trait in thread_aware crate Add traits module to reexport ThreadAware trait separately from derive macro Jan 5, 2026
Copilot AI requested a review from Darksecond January 5, 2026 11:24
@Darksecond Darksecond changed the title Add traits module to reexport ThreadAware trait separately from derive macro fix: Add traits module to reexport ThreadAware trait separately from derive macro Jan 5, 2026
@Darksecond Darksecond marked this pull request as ready for review January 5, 2026 11:25
//! feature is enabled).
#[doc(inline)]
pub use crate::core::ThreadAware;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not expose the trait directly from the core module?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name traits was suggested for the module name, I can for sure just expose it from core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(re-)export ThreadAware trait in thread_aware crate

5 participants