FIX: Suppress S360 SM05139 finding for DefaultAzureCredential in dev benchmark#637
Merged
Conversation
…mark Add CodeQL inline suppression comments to the credential-cache microbenchmark. The benchmark intentionally uses DefaultAzureCredential to measure credential instance caching overhead; it is a development-only tool, not product code.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a development-only microbenchmark to document/suppress a CodeQL (SM05139) finding triggered by intentional usage of DefaultAzureCredential, clarifying that the code is not product logic and is used purely for benchmarking credential instance caching overhead.
Changes:
- Added CodeQL suppression/justification comments next to
DefaultAzureCredential()inbench_no_cache. - Added CodeQL suppression/justification comments next to
DefaultAzureCredential()inbench_with_cache.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.9%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.pybind.ddbc_bindings.cpp: 76.2%
mssql_python.row.py: 76.9%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.logging.py: 85.5%
mssql_python.connection.py: 85.6%🔗 Quick Links
|
jahnvi480
approved these changes
Jun 23, 2026
subrata-ms
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request makes a minor documentation improvement to the
benchmarks/bench_credential_cache.pymicrobenchmark. It adds comments to clarify that the use ofDefaultAzureCredentialis intentional for benchmarking credential instance caching overhead and is not product code.bench_no_cacheandbench_with_cachefunctions to indicate intentional use ofDefaultAzureCredentialfor microbenchmarking, addressing CodeQL warning SM05139. [1] [2]