fix(docx): handle unknown math functions in OMML converter without crashing - #2268
Open
MeiSiristhebest wants to merge 2 commits into
Open
fix(docx): handle unknown math functions in OMML converter without crashing#2268MeiSiristhebest wants to merge 2 commits into
MeiSiristhebest wants to merge 2 commits into
Conversation
…nverter Do not set a default api_version string in DocumentIntelligenceConverter. If api_version is omitted or None, avoid passing api_version kwarg to DocumentIntelligenceClient so Azure SDK uses its native default version. Fixes microsoft#1904
…ashing
Add common standard math functions to FUNC dictionary in latex_dict.py and fallback to \operatorname{} for unknown functions in omml.py instead of throwing NotImplementedError.
Fixes microsoft#1982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OMML-to-LaTeX converter previously crashed with a
NotImplementedErrorwhen encountering math function names not present in theFUNCdictionary.This PR:
FUNCinlatex_dict.pywith 15 common standard LaTeX functions (log,ln,exp,det,gcd,lcm,lim,max,min,sup,inf,dim,ker,hom,deg,arg).raise NotImplementedErrorinomml.pywith a safe\operatorname{...}fallback so unlisted custom functions render as valid LaTeX without crashing conversion.Fixes #1982