fix(zip): skip directory entries in ZipConverter#1915
Open
nileshpatil6 wants to merge 1 commit into
Open
Conversation
zipObj.namelist() includes directory entries (e.g. 'docs/') that have no file content. Previously the converter tried to convert these zero-byte streams, producing empty '## File: docs/' headings in the output. Skip them with is_dir() before reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a ZIP archive contains explicit directory entries (e.g. created with
zipfile.ZipFile.mkdir()or tools like Info-ZIP),zipObj.namelist()returns those entries alongside actual files.Before this fix,
ZipConverterpassed every name tozipObj.read(), which returns an emptybytesobject for directory entries. That empty stream then went throughconvert_stream, and the result produced a spurious## File: subdir/heading with no content.Fix
Add an
is_dir()guard before reading and converting each entry:Reproduction