Skip to content

Return ESPIPE for pread/pwrite on non-seekable files#818

Merged
CvvT merged 2 commits intomainfrom
weiteng/handle_espipe
May 7, 2026
Merged

Return ESPIPE for pread/pwrite on non-seekable files#818
CvvT merged 2 commits intomainfrom
weiteng/handle_espipe

Conversation

@CvvT
Copy link
Copy Markdown
Contributor

@CvvT CvvT commented Apr 28, 2026

pread64/pwrite64 must fail with -ESPIPE when the file descriptor refers to a pipe, socket, FIFO, or any other non-seekable object.

@CvvT CvvT changed the title Return ESPIPE for pread/pwrite for non-seekable files Return ESPIPE for pread/pwrite on non-seekable files Apr 28, 2026
@CvvT CvvT marked this pull request as ready for review April 28, 2026 18:58
Copy link
Copy Markdown
Member

@jaybosamiya-ms jaybosamiya-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Weiteng, just a minor nit on naming

Comment thread litebox_shim_linux/src/syscalls/file.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

@CvvT CvvT added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 98d9432 May 7, 2026
13 checks passed
@CvvT CvvT deleted the weiteng/handle_espipe branch May 7, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants