Conversation
Contributor
Author
|
The second issue is also fixed in #754, but I feel it might be better to include it in this PR. |
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
sangho2
approved these changes
May 6, 2026
| let new_range = PageRange::new(new_range.start, new_range.end) | ||
| .ok_or(litebox::platform::page_mgmt::RemapError::Unaligned)?; | ||
| if old_range.start.max(new_range.start) <= old_range.end.min(new_range.end) { | ||
| if old_range.start.max(new_range.start) < old_range.end.min(new_range.end) { |
Contributor
There was a problem hiding this comment.
litebox_platform_lvbs/src/lib.rs:1269 does have the same problem. It would be better to fix these two together.
Comment on lines
+181
to
+182
| let old_size = align_up(old_size, PAGE_SIZE); | ||
| let new_size = align_up(new_size, PAGE_SIZE); |
Contributor
There was a problem hiding this comment.
checked_next_multiple_of() might be better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three issues in
mremapfound by AI.old_sizeandnew_sizeare rounded down to page boundary instead of up (Linux expects round-up).remap_pagescopies wrong chunk size, reading out-of-bounds on multi-page remaps.