Add support for old package.json license format#7
Merged
unindented merged 1 commit intomicrosoft:masterfrom Feb 3, 2019
Merged
Add support for old package.json license format#7unindented merged 1 commit intomicrosoft:masterfrom
unindented merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
As you say, there's no harm. Thank you for your contribution! |
Contributor
|
Ah nice, I just bumped into this problem as well and was about to open a PR to fix this 😇 Is a bugfix release planned anytime soon? |
Contributor
Contributor
|
Oh wait, I think this is not entirely fixed. In my case, a package has this format
So it's like singular |
Author
|
What a big mess it was before they implement the new rule to follow SPDX format :P I didn't notice that case was possible too. Indeed, it would be nice to have it more bullet proof ;) |
Contributor
|
Sure, no worries 😉 I just opened a PR and added some tests. Have a look please 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure we should support this here, because it's a deprecated format as we can see here: https://docs.npmjs.com/files/package.json#license so libraries should just adapt to it.
However, since there is no harm on having it, it could be nice to support that old format.
Reference: CodeSeven/toastr#604