docs(headless): revamp docsite with Overview, Getting Started, and Accessibility pages#36120
docs(headless): revamp docsite with Overview, Getting Started, and Accessibility pages#36120dmytrokirpa wants to merge 5 commits into
Conversation
…cessibility pages Restructure the headless components docsite navigation into Overview, Guides, Components, and Concepts groups. Replace the introduction page with a richer landing experience (hero + feature/why grids) and add Getting Started and Accessibility pages. Brand the Storybook chrome with a logo and rename the "Headless Components" story group to "Components". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
left a comment
There was a problem hiding this comment.
left some comments to discuss, otherwise nothin blocking
| @@ -0,0 +1,147 @@ | |||
| .hero { | |||
There was a problem hiding this comment.
is using css modules the path forward for everything ? it seems it's not the best approach and moves us to another vendor lock. eg for our storybook addon we used historically griffel, which is now in conflict when providing shared experiences across v9 and vH storybooks ( i have some work started where we switch to SB styled theming approach to be out of our own vendor lock )
to sum it up: if possible we should use generic styling solution for things outside code examples
There was a problem hiding this comment.
I don't have any preferences in regards of CSS Modules vs Griffel, I just wanted to re-use the same tokens/styles we have for the SB docs, and can easily convert it to Griffel if that's what we want to have in docs
| /** @type {typeof headlessPreview.parameters} */ | ||
| export const parameters = { | ||
| ...headlessPreview.parameters, | ||
| changelog: headlessChangelog, |
There was a problem hiding this comment.
is this some new native SB experience of rendering changelogs or how is this supposed to work ?
There was a problem hiding this comment.
It was an attempt to show the package changelog on a separate page, but it doesn't seem to be useful, so I reverted it.
This is leftover and also need to be reverted
There was a problem hiding this comment.
where are these coming from.
nit: why is the checkmark no centered ? looks odd
There was a problem hiding this comment.
all are AI generated, I'll fix the checkmark alignment
ty!
Summary
Headless Components/*toComponents/*across all stories (and the README example).