Skip to content

Check against sys.executable when determining if we should instrument subprocess #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Philip DePetro (pdepetro) wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Check against sys.executable when determining if we should instrument subprocess #2065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/debugpy/_vendored/pydevd/_pydev_bundle/pydev_monkey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ def is_python(path) -> bool:
if filename.find(name) != -1:
return True

if path == sys.executable:
return True

@rchiodo Rich Chiodo (rchiodo) Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning · Non-blocking recommendation

Raw equality accepts only the literal sys.executable spelling, so the same executable invoked through a symlink, relative path, or Windows case variation is still not recognized. Define whether this is intentionally an exact-path contract; if executable identity is intended, use a platform-aware path-equivalence check and cover alternate spellings.

@rchiodo Rich Chiodo (rchiodo) Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning · Non-blocking recommendation

Add a focused regression test that mocks an executable basename without python, jython, or pypy and verifies that is_python() recognizes it through sys.executable. The test should also establish the intended path-equivalence behavior.


return False


Expand Down
Loading