PS: API graph coverage improvements #317
Merged
+61
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better coverage for the
getInstance()predicate on API graphs. Previously, we did not support it for static "constructor-like" methods such as https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.aes.create?view=net-10.0#system-security-cryptography-aes-create. Commit 8c883e9 now ensures that you can do:and get the API node for
[System.Security.Cryptography.Aes]::Create().Along the way I also discovered that
getInstance()didnt work properly forNew-Object. So I fixed that in b3e1f57 and 0b06fcd.Finally, this PR also changes
getMemberso that it can select on only field reads, but also field writes. SogetMember("foo")will give back not justx.Foo, but alsox.Barin:Thanks for raising these issues, @chanel-y!