ci: enforce EditorConfig for YAML files - #18712
Draft
Tobias Brick (tobiasb-ms) wants to merge 2 commits into
Draft
ci: enforce EditorConfig for YAML files#18712Tobias Brick (tobiasb-ms) wants to merge 2 commits into
Tobias Brick (tobiasb-ms) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 15:56
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An existing YAML file violates the newly enforced final-newline rule, causing CI to fail.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extends EditorConfig enforcement to YAML files and updates contributor guidance.
Changes:
- Adds
.ymland.yamlto the pre-commit check. - Documents the expanded validation scope.
File summaries
| File | Description |
|---|---|
.pre-commit-config.yaml |
Expands the EditorConfig file filter. |
CONTRIBUTING.md |
Documents YAML validation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| hooks: | ||
| - id: editorconfig-checker | ||
| files: '\.toml$' | ||
| files: '\.(toml|ya?ml)$' |
Contributor
Author
There was a problem hiding this comment.
[Perihelion🚀] Correct. I normalized .pipelines/CodeQL/CodeQL.yml in a separate commit so the existing violation remains explicit and independently reviewable: 60352bd8f7.
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 19:48
View session
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Extend the existing pre-commit check so YAML files follow the repository-wide EditorConfig rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tobias Brick (tobiasb-ms)
force-pushed
the
tobiasb-ms/enforce-yaml-editorconfig
branch
from
September 4, 2026 22:56
60352bd to
d7ab293
Compare
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 22:57
View session
Tobias Brick (tobiasb-ms)
marked this pull request as ready for review
September 4, 2026 22:57
Tobias Brick (tobiasb-ms)
marked this pull request as draft
September 4, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the existing pre-commit EditorConfig check to
.ymland.yamlfiles and document the expanded scope.