Skip to content

fix(components): Remove python-impacket and drop its BuildRequires from curl#17040

Merged
christopherco merged 2 commits intotomls/base/mainfrom
anphel/rpm-signing-fix-impacket
May 7, 2026
Merged

fix(components): Remove python-impacket and drop its BuildRequires from curl#17040
christopherco merged 2 commits intotomls/base/mainfrom
anphel/rpm-signing-fix-impacket

Conversation

@anphel31
Copy link
Copy Markdown
Member

@anphel31 anphel31 commented May 5, 2026

fixes: AB#19811

Drop python-impacket and remove its only consumer in curl. python-impacket is failing RPM signing in the build pipeline. It has no runtime consumers in Azure Linux — its sole reference was a Fedora-gated BuildRequires in curl for upstream test 1451 (a Kerberos/SMB test that doesn't run in our build).

Validation:
Local build of curl
Control tower build / koji build

Confirm curl no longer depends on python-impacket

Before:
$ wget https://stcontroltowerdevjwisitg.blob.core.windows.net/alpha2-prod/base/srpms/Packages/c/curl-8.15.0-5.azl4~20260420.src.rpm
$ rpm -qp --requires curl-8.15.0-5.azl4~20260420.src.rpm | grep impacket 
python3-impacket
$

After:
$ rpm -qp --requires curl-8.15.0-6.azl4~20260420.src.rpm | grep impacket
$

@reubeno
Copy link
Copy Markdown
Member

reubeno commented May 5, 2026

Change looks reasonable, provided that there are no other build-time or runtime deps on it. If you do end up removing the package entirely, though, make sure to remove it from the components TOML and also all of its subpackages from the package TOML files under base/packages.

@anphel31 anphel31 changed the title remove python3-impacket fix(components): Remove python-impacket and drop its BuildRequires from curl May 5, 2026
@anphel31 anphel31 marked this pull request as ready for review May 5, 2026 21:39
Copilot AI review requested due to automatic review settings May 5, 2026 21:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes python-impacket from Azure Linux and drops the remaining curl build dependency that pulled it in, to avoid pipeline breakages and reduce unnecessary packaging surface area.

Changes:

  • Removed the python-impacket component from the distro (rendered specs, lock file, and SDK package list entry).
  • Added a dedicated curl.comp.toml overlay to remove BuildRequires: python3-impacket, and re-rendered curl.spec + updated curl.lock.
  • Updated base/comps/components.toml to reflect the move of curl to a dedicated component file and removal of python-impacket.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
specs/p/python-impacket/sources Removed rendered source checksum file as part of dropping the component.
specs/p/python-impacket/python-impacket.spec Removed rendered spec for the dropped component.
specs/p/python-impacket/python-impacket-0.12.0-pyopenssl.patch Removed rendered patch file for the dropped component.
specs/p/python-impacket/python-impacket-0.12.0-cleanup.patch Removed rendered patch file for the dropped component.
specs/c/curl/curl.spec Rendered spec updated to no longer BuildRequire python3-impacket.
locks/python-impacket.lock Removed lock file for the dropped component.
locks/curl.lock Updated lock fingerprint to reflect curl component config changes.
base/packages/sdk.packages.toml Removed python3-impacket from SDK package set.
base/comps/curl/curl.comp.toml New curl component overlay removing the python3-impacket BuildRequires.
base/comps/components.toml Removed python-impacket component entry and removed inline curl entry (now dedicated file).

Comment thread specs/c/curl/curl.spec
Comment thread base/comps/curl/curl.comp.toml
@anphel31 anphel31 force-pushed the anphel/rpm-signing-fix-impacket branch 2 times, most recently from 7cff9e7 to 6cedceb Compare May 6, 2026 03:03
@anphel31
Copy link
Copy Markdown
Member Author

anphel31 commented May 6, 2026

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 9e36b2c. The three conflicts were:

  • locks/curl.lock: kept our overlay fingerprint + added resolution-input-hash from base
  • locks/opencryptoki.lock: kept our opencryptoki 3.26.0 upstream commit + added resolution-input-hash
  • locks/python-impacket.lock: kept deleted (python-impacket is removed)

Change looks reasonable, provided that there are no other build-time or runtime deps on it. If you do end up removing the package entirely, though, make sure to remove it from the components TOML and ...

Confirmed — python-impacket has been fully removed: deleted from base/comps/components.toml, base/packages/sdk.packages.toml (python3-impacket), lock file (locks/python-impacket.lock), and rendered spec files (specs/p/python-impacket/). No other build-time or runtime consumers were found.

@anphel31 anphel31 force-pushed the anphel/rpm-signing-fix-impacket branch 2 times, most recently from 0c3974f to 00a6ec6 Compare May 6, 2026 20:43
anphel31 added 2 commits May 6, 2026 21:28
The python3-impacket BuildRequires only enables upstream test 1451
(Kerberos/SMB), and that test silently auto-skips when python3-impacket
is absent. Removing the BR is therefore a no-op for the curl build
itself.

This change unblocks dropping the python-impacket component from Azure
Linux entirely (it fails RPM signing in the build pipeline), which is
done in a follow-up commit.
python-impacket fails RPM signing in the build pipeline and has no
remaining consumers in Azure Linux:

  - Runtime: nothing in AZL Requires python3-impacket.
  - Build-time: only curl BuildRequires'd it (removed in the previous
    commit).

Removes the spec, patches, lock, components.toml entry, and
sdk.packages.toml entry.
@christopherco christopherco force-pushed the anphel/rpm-signing-fix-impacket branch from 00a6ec6 to 8a37654 Compare May 7, 2026 04:32
@christopherco
Copy link
Copy Markdown
Collaborator

I've split the commit out into 2 for further clarity, and updated their commit messages. Once CI passes, I'll merge

Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@christopherco christopherco merged commit 8e5bd89 into tomls/base/main May 7, 2026
10 checks passed
@christopherco christopherco deleted the anphel/rpm-signing-fix-impacket branch May 7, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants