fix(components): Remove python-impacket and drop its BuildRequires from curl#17040
Conversation
|
Change looks reasonable, provided that there are no other build-time or runtime deps on it. If you do end up removing the package entirely, though, make sure to remove it from the components TOML and also all of its subpackages from the package TOML files under |
There was a problem hiding this comment.
Pull request overview
Removes python-impacket from Azure Linux and drops the remaining curl build dependency that pulled it in, to avoid pipeline breakages and reduce unnecessary packaging surface area.
Changes:
- Removed the
python-impacketcomponent from the distro (rendered specs, lock file, and SDK package list entry). - Added a dedicated
curl.comp.tomloverlay to removeBuildRequires: python3-impacket, and re-renderedcurl.spec+ updatedcurl.lock. - Updated
base/comps/components.tomlto reflect the move ofcurlto a dedicated component file and removal ofpython-impacket.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/p/python-impacket/sources | Removed rendered source checksum file as part of dropping the component. |
| specs/p/python-impacket/python-impacket.spec | Removed rendered spec for the dropped component. |
| specs/p/python-impacket/python-impacket-0.12.0-pyopenssl.patch | Removed rendered patch file for the dropped component. |
| specs/p/python-impacket/python-impacket-0.12.0-cleanup.patch | Removed rendered patch file for the dropped component. |
| specs/c/curl/curl.spec | Rendered spec updated to no longer BuildRequire python3-impacket. |
| locks/python-impacket.lock | Removed lock file for the dropped component. |
| locks/curl.lock | Updated lock fingerprint to reflect curl component config changes. |
| base/packages/sdk.packages.toml | Removed python3-impacket from SDK package set. |
| base/comps/curl/curl.comp.toml | New curl component overlay removing the python3-impacket BuildRequires. |
| base/comps/components.toml | Removed python-impacket component entry and removed inline curl entry (now dedicated file). |
7cff9e7 to
6cedceb
Compare
|
@copilot resolve the merge conflicts in this pull request |
Merge conflicts resolved in 9e36b2c. The three conflicts were:
Confirmed — |
0c3974f to
00a6ec6
Compare
The python3-impacket BuildRequires only enables upstream test 1451 (Kerberos/SMB), and that test silently auto-skips when python3-impacket is absent. Removing the BR is therefore a no-op for the curl build itself. This change unblocks dropping the python-impacket component from Azure Linux entirely (it fails RPM signing in the build pipeline), which is done in a follow-up commit.
python-impacket fails RPM signing in the build pipeline and has no
remaining consumers in Azure Linux:
- Runtime: nothing in AZL Requires python3-impacket.
- Build-time: only curl BuildRequires'd it (removed in the previous
commit).
Removes the spec, patches, lock, components.toml entry, and
sdk.packages.toml entry.
00a6ec6 to
8a37654
Compare
|
I've split the commit out into 2 for further clarity, and updated their commit messages. Once CI passes, I'll merge |
fixes: AB#19811
Drop
python-impacketand remove its only consumer incurl.python-impacketis failing RPM signing in the build pipeline. It has no runtime consumers in Azure Linux — its sole reference was a Fedora-gated BuildRequires in curl for upstream test 1451 (a Kerberos/SMB test that doesn't run in our build).Validation:
Local build of curl
Control tower build / koji build
Confirm curl no longer depends on python-impacket