-
Notifications
You must be signed in to change notification settings - Fork 626
fix(sos): add cloud-init-main and cloud-init-network service names #17025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ddstreetmicrosoft
merged 1 commit into
microsoft:tomls/base/main
from
jonathanbrenes:fix/sos-cloud-init-services
May 8, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
base/comps/sos/cloud_init-add-cloud-init-main-and-network-services.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| From 91154c0c3b2a2aa9076ee34cea62dd4cc8f1ad04 Mon Sep 17 00:00:00 2001 | ||
| From: Jonathan Brenes <jonathan.brenes@microsoft.com> | ||
| Date: Wed, 29 Apr 2026 11:42:05 -0600 | ||
| Subject: [PATCH] fix(cloud_init): add cloud-init-main and cloud-init-network | ||
| service names | ||
|
|
||
| cloud-init 24.3 introduced a "single process optimization" | ||
| (canonical/cloud-init#5489, merged Aug 2, 2024) that renamed | ||
| cloud-init.service to cloud-init-network.service and added a new | ||
| cloud-init-main.service as the primary single-process service. | ||
|
|
||
| Distros shipping cloud-init >= 24.3 no longer have a | ||
| cloud-init.service unit. The sos cloud_init plugin only listed | ||
| cloud-init.service, so it failed to collect service status and | ||
| journal logs for the new service names on these distros. | ||
|
|
||
| Adding cloud-init-main and cloud-init-network to the services tuple | ||
| is backward-compatible: sos will simply skip services that do not | ||
| exist on a given system. | ||
|
|
||
| Ref: https://github.com/canonical/cloud-init/pull/5489 | ||
| Ref: https://github.com/canonical/cloud-init/commit/143bc9e | ||
| Ref: https://discourse.ubuntu.com/t/announcement-cloud-init-perfomance-optimization-single-process/47505 | ||
| Signed-off-by: Jonathan Brenes <jonathan.brenes@microsoft.com> | ||
| --- | ||
| sos/report/plugins/cloud_init.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/sos/report/plugins/cloud_init.py b/sos/report/plugins/cloud_init.py | ||
| index a76e751ad5..cc16163902 100644 | ||
| --- a/sos/report/plugins/cloud_init.py | ||
| +++ b/sos/report/plugins/cloud_init.py | ||
| @@ -17,7 +17,7 @@ class CloudInit(Plugin, IndependentPlugin): | ||
|
|
||
| plugin_name = 'cloud_init' | ||
| packages = ('cloud-init',) | ||
| - services = ('cloud-init',) | ||
| + services = ('cloud-init', 'cloud-init-main', 'cloud-init-network') | ||
|
|
||
| def setup(self): | ||
|
|
||
| -- | ||
| 2.49.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
specs/s/sos/cloud_init-add-cloud-init-main-and-network-services.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| From 91154c0c3b2a2aa9076ee34cea62dd4cc8f1ad04 Mon Sep 17 00:00:00 2001 | ||
| From: Jonathan Brenes <jonathan.brenes@microsoft.com> | ||
| Date: Wed, 29 Apr 2026 11:42:05 -0600 | ||
| Subject: [PATCH] fix(cloud_init): add cloud-init-main and cloud-init-network | ||
| service names | ||
|
|
||
| cloud-init 24.3 introduced a "single process optimization" | ||
| (canonical/cloud-init#5489, merged Aug 2, 2024) that renamed | ||
| cloud-init.service to cloud-init-network.service and added a new | ||
| cloud-init-main.service as the primary single-process service. | ||
|
|
||
| Distros shipping cloud-init >= 24.3 no longer have a | ||
| cloud-init.service unit. The sos cloud_init plugin only listed | ||
| cloud-init.service, so it failed to collect service status and | ||
| journal logs for the new service names on these distros. | ||
|
|
||
| Adding cloud-init-main and cloud-init-network to the services tuple | ||
| is backward-compatible: sos will simply skip services that do not | ||
| exist on a given system. | ||
|
|
||
| Ref: https://github.com/canonical/cloud-init/pull/5489 | ||
| Ref: https://github.com/canonical/cloud-init/commit/143bc9e | ||
| Ref: https://discourse.ubuntu.com/t/announcement-cloud-init-perfomance-optimization-single-process/47505 | ||
| Signed-off-by: Jonathan Brenes <jonathan.brenes@microsoft.com> | ||
| --- | ||
| sos/report/plugins/cloud_init.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/sos/report/plugins/cloud_init.py b/sos/report/plugins/cloud_init.py | ||
| index a76e751ad5..cc16163902 100644 | ||
| --- a/sos/report/plugins/cloud_init.py | ||
| +++ b/sos/report/plugins/cloud_init.py | ||
| @@ -17,7 +17,7 @@ class CloudInit(Plugin, IndependentPlugin): | ||
|
|
||
| plugin_name = 'cloud_init' | ||
| packages = ('cloud-init',) | ||
| - services = ('cloud-init',) | ||
| + services = ('cloud-init', 'cloud-init-main', 'cloud-init-network') | ||
|
|
||
| def setup(self): | ||
|
|
||
| -- | ||
| 2.49.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.