fix: handle -l flag in spec section header package name extraction#180
Merged
Conversation
[GetPackageNameFromSectionHeader] did not recognize the '-l' flag used in localized %description sections (e.g. '%description -l fr subpkg'). The language code was incorrectly parsed as the package name suffix, causing [RemoveSubpackage] to miss localized description sections when removing a subpackage. Add '-l' to the flag switch with 'index += 2' to skip both the flag and the language code, matching the behavior of '-f' and '-p'.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes RPM spec section header parsing so localized %description headers using -l <lang> don’t misinterpret the language code as the package name suffix, which in turn allows subpackage removal logic to correctly match localized description sections.
Changes:
- Teach
GetPackageNameFromSectionHeaderto recognize and skip the-lflag plus its language argument. - Add unit tests covering
%description -l <lang> ...token patterns, including combinations with-n.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/rpm/spec/spec.go | Extends section-header token parsing to skip the -l flag and its language token when extracting package names. |
| internal/rpm/spec/spec_test.go | Adds regression tests ensuring -l doesn’t affect extracted package names and handles missing suffix/name cleanly. |
reubeno
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GetPackageNameFromSectionHeader] did not recognize the '-l' flag used in localized %description sections (e.g. '%description -l fr subpkg'). The language code was incorrectly parsed as the package name suffix, causing [RemoveSubpackage] to miss localized description sections when removing a subpackage.
Add '-l' to the flag switch with 'index += 2' to skip both the flag and the language code, matching the behavior of '-f' and '-p'.
Fixes #142