Fix: Validate reserved keywords in checkpoint serialization and verify types during deserialization #3243
+153
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reserved checkpoint markers (
__af_model__and__af_dataclass__) used for polymorphic serialization could be spoofed by arbitrary dicts, causing incorrect type instantiation during deserialization. Additionally, deserialization didn't verify that loaded classes actually matched their claimed type (dataclass or model protocol).Description
Serialization validation:
ValueErrorif a dict contains reserved marker keys with avaluekey (the marker pattern)Deserialization validation:
DATACLASS_MARKERclasses are actually dataclass types viaisinstance(cls, type) and is_dataclass(cls)MODEL_MARKERclasses support model protocol (to_dict/from_dictorto_json/from_jsonpairs)Refactoring:
_class_supports_model_protocol(cls)helper;_supports_model_protocol(obj)now delegates to itContribution Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.