Add SKIP_TEST_SERVER macro and skip BuildImageStuckCallbackCancellation#40448
Merged
Add SKIP_TEST_SERVER macro and skip BuildImageStuckCallbackCancellation#40448
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CI hang on Windows Server SKUs by conditionally skipping the BuildImageStuckCallbackCancellation test in WSLCTests.cpp, aligning it with existing Server-SKU skip behavior already used for other image-related tests in the same file.
Changes:
- Skip
BuildImageStuckCallbackCancellationwhenIsWindowsServer()is true. - Add inline comments noting the Server-SKU hang and that the skip is temporary (TODO to remove once fixed).
Several WSLC tests hang on Windows Server SKUs. Introduce a
SKIP_TEST_SERVER() macro alongside the existing SKIP_TEST_ARM64 /
SKIP_TEST_UNSTABLE helpers, and use it for:
- LoadImage
- ImportImage
- BuildImageStuckCallbackCancellation (newly skipped; was timing
out the wslc fe_release CI session at the 2-hour PhaseTimeout)
This replaces the ad-hoc IsWindowsServer() / SKIP_TEST_UNSTABLE
blocks with TODO comments that were starting to be sprinkled across
the file.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
force-pushed
the
fix/skip-buildimage-stuck-callback-server
branch
from
08635ac to
93305a9
Compare
benhillis
changed the title
OneBlue
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several WSLC tests hang on Windows Server SKUs. Adds a
SKIP_TEST_SERVER()macro alongside the existingSKIP_TEST_ARM64/SKIP_TEST_UNSTABLEhelpers intest/windows/Common.h, and uses it for:LoadImageImportImageBuildImageStuckCallbackCancellation(newly skipped — was timing out the wslc fe_release CI session at the 2-hour PhaseTimeout,te.exeexit 1818)Investigation of a recent failed
BuildImageStuckCallbackCancellationsession confirms the hang point: the TAEF console log ends mid-test at theVERIFY_ARE_EQUAL(reachedStatus, std::future_status::ready)line with no log entry for the immediately followingVERIFY_SUCCEEDED(m_defaultSession->Terminate()).Terminate()is blocking forever — it cannot abort the in-flightBuildImagecall while theStuckBuildProgressCallbackis blocked insideOnProgress. The underlyingTerminate()cancellation issue is tracked separately.The new macro replaces the ad-hoc
IsWindowsServer()+ TODO comment blocks that were starting to be sprinkled across the file.