Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new top-level system command group in the WSLC CLI and moves the existing session command tree underneath it, aligning session management under a system-scoped namespace.
Changes:
- Add
SystemCommandand register it underRootCommand;SessionCommandis now reached viawslc system session .... - Update CLI parsing/unit/E2E tests to use the new command path.
- Add localized descriptions for the new
systemcommand.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/WSLCCLICommandUnitTests.cpp | Adds coverage for SystemCommand and updates session-related unit tests to the new command path. |
| test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp | Updates E2E command invocations and root help expectations to include system instead of top-level session. |
| test/windows/wslc/CommandLineTestCases.h | Updates command-line parsing test cases to system session .... |
| src/windows/wslc/commands/SystemCommand.h | Declares the new SystemCommand root command. |
| src/windows/wslc/commands/SystemCommand.cpp | Implements SystemCommand and wires SessionCommand as a subcommand. |
| src/windows/wslc/commands/RootCommand.cpp | Registers SystemCommand at the root (and removes top-level SessionCommand). |
| localization/strings/en-US/Resources.resw | Adds localized strings for system command short/long descriptions. |
| </data> | ||
| <data name="WSLCCLI_SystemCommandDesc" xml:space="preserve"> | ||
| <value>System-level commands</value> | ||
| <comment>{Locked="WSL"}Product names should not be translated</comment> |
Comment on lines
33
to
38
| commands.push_back(std::make_unique<ContainerCommand>(FullName())); | ||
| commands.push_back(std::make_unique<ImageCommand>(FullName())); | ||
| commands.push_back(std::make_unique<RegistryCommand>(FullName())); | ||
| commands.push_back(std::make_unique<SessionCommand>(FullName())); | ||
| commands.push_back(std::make_unique<SettingsCommand>(FullName())); | ||
| commands.push_back(std::make_unique<SystemCommand>(FullName())); | ||
| commands.push_back(std::make_unique<VolumeCommand>(FullName())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds system command, with the existing "session" command under it.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added new root subcommand "system"
Moved existing "session" command to be under it.
Updated unit tests.
Updated E2E tests.
Validation Steps Performed
Ran unit tests