Don't try to read from the early console if EarlyBootDmesg is disabled#14138
Merged
OneBlue merged 1 commit intofeature/wsl-for-appsfrom Feb 2, 2026
Merged
Don't try to read from the early console if EarlyBootDmesg is disabled#14138OneBlue merged 1 commit intofeature/wsl-for-appsfrom
OneBlue merged 1 commit intofeature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WSLA VM boot path so that the dmesg collector only attaches to the early-boot serial console when early boot logging is actually enabled, avoiding unnecessary thread creation and expected E_ABORT errors on shutdown.
Changes:
- Passes
FeatureEnabled(WslaFeatureFlagsEarlyBootDmesg)intoDmesgCollector::Createto conditionally enable the early boot console consumer instead of always enabling it. - Keeps the existing
FeatureEnabled(WslaFeatureFlagsEarlyBootDmesg)gating for kernel command lineearlyconand COM1 configuration, maintaining consistency between producer and consumer of early boot logs.
benhillis
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
This change updates the dmesg collector to not try to read from the early boot serial if early boot logging is disabled.
This avoids creating an essentially useless thread, and this error when the session terminates:
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed