FIX: validate fixed AddImageText font size - #2563
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
FIX: validate fixed AddImageText font size#2563Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AddImageTextConvertervalidates automatic(min, max)font-size ranges to require positive sizes, but fixed integerfont_sizevalues are accepted without validation.Values such as
font_size=0or a negative size therefore reach Pillow's font loader and fail there instead of being rejected as invalid converter configuration.This change applies the same positive-size invariant to fixed font sizes and raises a clear
ValueErrorduring initialization.Tests
Adds regression coverage for zero and negative fixed font sizes.