FEAT add TargetConfiguration & pieces#1573
Merged
hannahwestra25 merged 14 commits intomicrosoft:mainfrom Apr 8, 2026
Merged
Conversation
behnam-o
reviewed
Apr 7, 2026
…ra/add_target_config_pieces
behnam-o
approved these changes
Apr 7, 2026
jsong468
reviewed
Apr 7, 2026
jsong468
reviewed
Apr 7, 2026
jsong468
reviewed
Apr 7, 2026
jsong468
reviewed
Apr 7, 2026
pyrit/prompt_target/common/conversation_normalization_pipeline.py
Outdated
Show resolved
Hide resolved
jsong468
reviewed
Apr 7, 2026
jsong468
reviewed
Apr 7, 2026
pyrit/prompt_target/common/conversation_normalization_pipeline.py
Outdated
Show resolved
Hide resolved
jsong468
reviewed
Apr 7, 2026
jsong468
approved these changes
Apr 7, 2026
Contributor
jsong468
left a comment
jsong468
left a comment
There was a problem hiding this comment.
Thanks for a great design spec and clean implementation :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is 2 of ~5 PRs to introduce/integrate TargetConfiguration. This PR adds TargetConfiguration and the necessary pieces within it. This will replace the current pattern where capability checks, normalization, and error handling are scattered across targets, attacks, converters, and scorers.
NOTE: this just adds the classes, does not replace any of the current logic nor is it used anywhere in this PR
New classes:
Full spec: https://microsoft-my.sharepoint.com/:w:/p/hannahwestra/cQoo3V80Zd4FTafKPqjDmr4vEgUCBfTfToMrXUEegSaVhFPj2A
Tests and Documentation
added tests