Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c19206a to
d0c9114
Compare
b7c22c1 to
9b3a3be
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds WinML 2.0 “preview” verification samples across multiple SDKs and updates the SDKs/pipelines to support execution-provider (EP) discovery + download/registration flows and WinML-targeting changes.
Changes:
- Add new “verify-winml” samples for C++, C#, Python, JavaScript, and Rust, plus update existing audio transcription samples to align with newer streaming/download APIs.
- Extend the C++ SDK manager to support EP discovery and EP download/registration with optional progress reporting, and invalidate the catalog cache after EP changes.
- Update WinML target framework/min-version pins across .NET projects and pipeline build steps; adjust JS WinML installer robustness and fix C# catalog ordering behavior.
Reviewed changes
Copilot reviewed 46 out of 48 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/requirements-winml.txt | Formatting fix in WinML Python requirements file. |
| sdk/js/script/install-winml.cjs | Adds more robust logic to locate the SDK root when running the WinML installer script. |
| sdk/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj | Updates WinML target framework/min-version for C# tests. |
| sdk/cs/test/FoundryLocal.Tests/CatalogTests.cs | Adds a test ensuring model listing preserves Core-provided ordering. |
| sdk/cs/src/Microsoft.AI.Foundry.Local.csproj | Updates WinML target framework/min-version for the C# SDK package. |
| sdk/cs/src/Catalog.cs | Preserves Core ordering by tracking models in insertion order rather than sorting by alias. |
| sdk/cpp/src/foundry_local_manager.cpp | Adds EP discovery/download APIs, progress callback wiring, bootstrap auto-setting, and catalog cache invalidation. |
| sdk/cpp/src/core.h | Makes execute_command_with_binary optional and returns a descriptive error for unsupported Core versions. |
| sdk/cpp/src/catalog.cpp | Adds InvalidateCache() to refresh the catalog after EP registration changes. |
| sdk/cpp/include/foundry_local_manager.h | Exposes EP discovery/download result structs and download APIs (with progress callback). |
| sdk/cpp/include/catalog.h | Exposes Catalog::InvalidateCache(). |
| sdk/cpp/CMakeLists.txt | Adds ole32 link dependency. |
| samples/rust/verify-winml/src/main.rs | New Rust WinML EP verification sample (discover/register EPs, find accelerated variants, streaming chat check). |
| samples/rust/verify-winml/README.md | Documentation for the new Rust WinML verification sample. |
| samples/rust/verify-winml/Cargo.toml | Cargo manifest for the new Rust sample. |
| samples/rust/live-audio-transcription/src/main.rs | Updates the Rust live audio transcription sample to newer SDK APIs/types. |
| samples/rust/Cargo.toml | Adds live-audio-transcription and verify-winml to the Rust samples workspace members. |
| samples/README.md | Adds a C++ samples row to the “Samples by Language” table. |
| samples/python/verify-winml/src/app.py | New Python WinML EP verification script. |
| samples/python/verify-winml/requirements.txt | Adds a WinML-flavored Python SDK dependency for the new sample. |
| samples/python/verify-winml/README.md | Documentation for the new Python WinML verification sample. |
| samples/js/verify-winml/README.md | Documentation for the new JS WinML verification sample. |
| samples/js/verify-winml/package.json | New JS WinML verification sample package with postinstall WinML setup. |
| samples/js/verify-winml/app.js | New JS WinML EP verification script. |
| samples/cs/verify-winml/VerifyWinML.csproj | New C# WinML EP verification sample project. |
| samples/cs/verify-winml/README.md | Documentation for the new C# WinML verification sample. |
| samples/cs/verify-winml/Program.cs | New C# WinML EP verification program. |
| samples/cs/tutorial-voice-to-text/TutorialVoiceToText.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/tutorial-tool-calling/TutorialToolCalling.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/tutorial-document-summarizer/TutorialDocumentSummarizer.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/tutorial-chat-assistant/TutorialChatAssistant.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/tool-calling-foundry-local-web-server/ToolCallingFoundryLocalWebServer.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/tool-calling-foundry-local-sdk/ToolCallingFoundryLocalSdk.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/nuget.config | Formatting/newline normalization. |
| samples/cs/native-chat-completions/NativeChatCompletions.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/model-management-example/ModelManagementExample.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/live-audio-transcription/LiveAudioTranscriptionExample.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/foundry-local-web-server/FoundryLocalWebServer.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/embeddings/Embeddings.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cs/Directory.Packages.props | Pins Microsoft.AI.Foundry.Local.Core.WinML to 1.0.0 for samples. |
| samples/cs/audio-transcription-example/AudioTranscriptionExample.csproj | Updates Windows target framework version for WinML acceleration. |
| samples/cpp/verify-winml/README.md | Documentation for the new C++ WinML verification sample. |
| samples/cpp/verify-winml/main.cpp | New C++ WinML EP verification sample implementation. |
| samples/cpp/verify-winml/CMakeLists.txt | CMake project for building the new C++ verify-winml sample. |
| samples/cpp/live-audio-transcription/README.md | Switches build instructions to CMake and documents runtime/native DLL placement. |
| samples/cpp/live-audio-transcription/main.cpp | Improves model alias handling and error messaging for missing live-audio model. |
| samples/cpp/live-audio-transcription/CMakeLists.txt | Adds a CMake project for the C++ live-audio-transcription sample. |
| .pipelines/templates/build-core-steps.yml | Updates WinML build/test/publish TFMs used by the pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5359409 to
8d1b5fc
Compare
8d1b5fc to
4e793f8
Compare
4e793f8 to
b77e19e
Compare
b77e19e to
93db383
Compare
93db383 to
c18604e
Compare
Add the WinML 2.0 verification samples and the minimal SDK, packaging, and target-framework support required to run them against the preview WinML stack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c18604e to
4934aca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.