feat(server): upgrade server/routerlicious to ESLint 9 with flat config #26192
+1,947
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate the server/routerlicious workspace from ESLint 8 with eslintrc to ESLint 9 with flat config (eslint.config.mts files). Changes: - Add ESLint 9 and all required plugin dependencies to workspace root - Create shared eslint.config.base.mts with routerlicious-specific overrides - Convert all 20 packages to flat config format - Remove deprecated .eslintrc.cjs and .eslintignore files - Use link: protocol to reference shared eslint-config-fluid from common/build
Document the transitive dependency workaround required when using the link: protocol to reference eslint-config-fluid. Lists all duplicated ESLint plugin dependencies and explains when the workaround can be removed (when eslint-config-fluid is published to npm or workspaces are consolidated).
Add common/build/eslint-config-fluid to the pipeline trigger paths since server/routerlicious now depends on the shared ESLint config via link: protocol. This ensures the pipeline runs when ESLint rules change.
tylerbutler
commented
Jan 13, 2026
tylerbutler
commented
Jan 13, 2026
tylerbutler
commented
Jan 13, 2026
tylerbutler
commented
Jan 13, 2026
…feed 404s Pin package versions to avoid 404 errors when CI fetches packages from the Azure DevOps package feed. The following newly released versions were not yet available in the ADO publicPackages feed: - @typescript-eslint/[email protected] -> 8.52.0 - @typescript-eslint/[email protected] -> 8.52.0 - @babel/* 7.28.x -> 7.27.x These overrides can be removed once the packages are mirrored to ADO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
server/routerliciousworkspace from ESLint 8 (eslintrc format) to ESLint 9 (flat config format).eslint.config.base.mtswith routerlicious-specific rule overrides.eslintrc.cjstoeslint.config.mts.eslintignorefiles (patterns now in flat config)link:protocol to reference sharedeslint-config-fluidfromcommon/buildDEV.mddocumenting the transitive dependency workaround for thelink:protocolThis mirrors the ESLint 9 migration done for the
build-toolsworkspace in thebt-eslint9branch.