Gate Add/Close-All on open logs and Security/State on admin elevation#508
Merged
Gate Add/Close-All on open logs and Security/State on admin elevation#508
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MAUI/Blazor menu behavior to better reflect application state (open logs) and security context (admin elevation), while avoiding duplicate live log entries in dynamic enumeration.
Changes:
- Disable “Combine” and “Close All” when no logs are currently open.
- Gate admin-only live logs (e.g., Security/State) in the Live log menu based on elevation.
- Filter dynamically-enumerated live logs to exclude those already hard-coded in the menu, and add tests for the new log name sets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/EventLogExpert/Shared/Components/Menu/MenuBar.razor.cs | Adds state-driven enable/disable for menu items and admin gating for certain live logs. |
| src/EventLogExpert/Services/MauiMenuActionService.cs | Filters dynamically enumerated log names to avoid duplicates with the hard-coded Live menu items. |
| src/EventLogExpert.UI/LogNameMethods.cs | Introduces centralized sets for admin-only and hard-coded live log names. |
| src/EventLogExpert.UI.Tests/LogNameMethodsTests.cs | Adds unit tests covering the new log name sets (contents and case-insensitivity). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jschick04
force-pushed
the
jschick/update_filemenu
branch
from
dc34f2c to
74f5a90
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bill-long
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.