Open
Conversation
jablko
force-pushed
the
patch-43
branch
3 times, most recently
from
90f8632 to
4071a8b
Compare
jablko
commented
May 4, 2022
| log(` git add --all && git commit -m "${name}: Provides its own types" && git push -u origin not-needed-${name}`); | ||
| log(` And comment PR: This will deprecate \`@types/${name}\` in favor of just \`${name}\`. CC ${contributorUrls}`); | ||
| if (semver.gt(`${major}.${minor}.0`, firstTypedVersion)) { | ||
| if (semver.gte(`${major}.${minor}.0`, firstTypedVersion)) { |
Contributor
Author
There was a problem hiding this comment.
Make the condition slightly more correct, same as
and .
jablko
added a commit
to jablko/DefinitelyTyped
that referenced
this pull request
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we relax this condition (not-need version must be newer than the
@types/packageversion)? It prevents the removal of types that are newer than their target package, and doesn't make a difference to the stub's version, which anyway will be the max of the not-needed version and the max@types/packageversion + 1. e.g.@types/angular-ui-routerversion is 1.1.41.angular-ui-router's versions satisfies this condition (is newer than 1.1.41).