Skip to content

Add antd the list of allowed packages#1248

Closed
retrozy1 wants to merge 1 commit intomicrosoft:mainfrom
retrozy1:antd
Closed

Add antd the list of allowed packages#1248
retrozy1 wants to merge 1 commit intomicrosoft:mainfrom
retrozy1:antd

Conversation

@retrozy1
Copy link

@retrozy1 retrozy1 commented Feb 2, 2026

@jakebailey
Copy link
Member

In what capacity will it be used? For tests only? Or as an actual dep? (Usually people discover they need to update this after they have a PR and so we see what's going on)

@retrozy1
Copy link
Author

retrozy1 commented Feb 2, 2026

This will be used for an actual dependency, as Gimloader will provide an api to installers that interacts with antd api

@jakebailey
Copy link
Member

And it's not avoidable? antd is a huge dep, it's pretty surprising to hard dep on it in a public API and not just define some extra types. But if it must be, then...

@retrozy1
Copy link
Author

retrozy1 commented Feb 5, 2026

If it's undesirable to have the package installed that's all fine, there's a system being written to generate the types automatically from the imports (it would be ~350 lines to manually extract)

@retrozy1 retrozy1 closed this Feb 5, 2026
@jakebailey
Copy link
Member

It's fine if users are going to have it installed anyway and it's a regular dep. I just wanted to check.

@retrozy1 retrozy1 deleted the antd branch February 5, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants