Add antd the list of allowed packages#1248
Conversation
|
In what capacity will it be used? For tests only? Or as an actual dep? (Usually people discover they need to update this after they have a PR and so we see what's going on) |
|
This will be used for an actual dependency, as Gimloader will provide an api to installers that interacts with antd api |
|
And it's not avoidable? antd is a huge dep, it's pretty surprising to hard dep on it in a public API and not just define some extra types. But if it must be, then... |
|
If it's undesirable to have the package installed that's all fine, there's a system being written to generate the types automatically from the imports (it would be ~350 lines to manually extract) |
|
It's fine if users are going to have it installed anyway and it's a regular dep. I just wanted to check. |
This is needed for a future commit to https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/gimloader