Add [GeneratedCustomPropertyProvider] generator and analyzers

build/AzurePipelineTemplates/CsWinRT-Test-Steps.yml

@@ -22,6 +22,18 @@ steps:
         --no-build
       testRunTitle: Unit Tests
 
+# Run Source Generator 2 Tests
+  - task: DotNetCoreCLI@2
+    displayName: Run Source Generator 2 Tests
+    condition: and(succeeded(), or(eq(variables['BuildPlatform'], 'x86'), eq(variables['BuildPlatform'], 'x64')))
+    inputs:
+      command: test
+      projects: 'src/Tests/SourceGenerator2Test/SourceGenerator2Test.csproj'
+      arguments: >
+        /p:platform=$(BuildPlatform);configuration=$(BuildConfiguration)
+        --no-build
+      testRunTitle: Source Generator 2 Tests
+
 # Run Host Tests
   - task: CmdLine@2
     displayName: Run Host Tests

src/Authoring/WinRT.SourceGenerator2/AnalyzerReleases.Shipped.md

@@ -0,0 +1,17 @@
+; Shipped analyzer releases
+; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
+
+## Release 3.0.0
+
+### New Rules
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-------
+CSWINRT2000 | WindowsRuntime.SourceGenerator | Error | Invalid '[GeneratedCustomPropertyProvider]' target type
+CSWINRT2001 | WindowsRuntime.SourceGenerator | Error | Missing 'partial' for '[GeneratedCustomPropertyProvider]' target type
+CSWINRT2002 | WindowsRuntime.SourceGenerator | Error | 'ICustomPropertyProvider' interface type not available
+CSWINRT2003 | WindowsRuntime.SourceGenerator | Error | Existing 'ICustomPropertyProvider' member implementation
+CSWINRT2004 | WindowsRuntime.SourceGenerator | Error | Null property name in '[GeneratedCustomPropertyProvider]'
+CSWINRT2005 | WindowsRuntime.SourceGenerator | Error | Null indexer type in '[GeneratedCustomPropertyProvider]'
+CSWINRT2006 | WindowsRuntime.SourceGenerator | Error | Property name not found for '[GeneratedCustomPropertyProvider]'
+CSWINRT2007 | WindowsRuntime.SourceGenerator | Error | Indexer type not found for '[GeneratedCustomPropertyProvider]'
+CSWINRT2008 | WindowsRuntime.SourceGenerator | Error | Static indexer for '[GeneratedCustomPropertyProvider]'

src/Authoring/WinRT.SourceGenerator2/AnalyzerReleases.Unshipped.md

@@ -0,0 +1,6 @@
+; Unshipped analyzer release
+; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
+
+### New Rules
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-------

src/Authoring/WinRT.SourceGenerator2/AuthoringExportTypesGenerator.Execute.cs

@@ -112,7 +112,7 @@ public static void EmitManagedExports(SourceProductionContext context, Authoring
                 return;
             }
 
-            IndentedTextWriter writer = new(literalLength: 0, formattedCount: 0);
+            IndentedTextWriter writer = new(literalLength: 0, formattedCount: 0); // TODO: adjust the literal length
 
             // Emit the '[WindowsRuntimeComponentAssemblyExportsType]' attribute so other tooling (including this same generator)
             // can reliably find the generated export types from other assemblies, which is needed when merging activation factories.
@@ -134,14 +134,14 @@ namespace ABI.{{info.AssemblyName.EscapeIdentifierName()}};
                 /// <summary>
                 /// Contains the managed exports for activating types from the current project in an authoring scenario.
                 /// </summary>
-                """);
+                """, isMultiline: true);
 
             // Emit the standard generated attributes, and also mark the type as hidden, since it's generated as a public type
             writer.WriteGeneratedAttributes(nameof(AuthoringExportTypesGenerator), useFullyQualifiedTypeNames: false);
             writer.WriteLine($$"""
                 [EditorBrowsable(EditorBrowsableState.Never)]
                 public static unsafe class ManagedExports
-                """);
+                """, isMultiline: true);
 
             // Indent via a block, as we'll also need to emit custom logic for the activation factory
             using (writer.WriteBlock())
@@ -155,7 +155,7 @@ public static unsafe class ManagedExports
                     /// <param name="activatableClassId">The class identifier that is associated with an activatable runtime class.</param>
                     /// <returns>The resulting pointer to the activation factory that corresponds with the class specified by <paramref name="activatableClassId"/>.</returns>
                     public static void* GetActivationFactory(ReadOnlySpan<char> activatableClassId)
-                    """);
+                    """, isMultiline: true);
 
                 using (writer.WriteBlock())
                 {
@@ -167,7 +167,7 @@ public static unsafe class ManagedExports
                             static extern void* AuthoringGetActivationFactory(
                                 [UnsafeAccessorType("ABI.{info.AssemblyName.EscapeIdentifierName()}.ManagedExports, WinRT.Authoring")] object? _,
                                 ReadOnlySpan<char> activatableClassId);
-                            """);
+                            """, isMultiline: true);
                     }
 
                     // Emit the specialized code to redirect the activation
@@ -181,7 +181,7 @@ public static unsafe class ManagedExports
                             void* activationFactory = AuthoringGetActivationFactory(null, activatableClassId);
 
                             return activationFactory ?? ReferencedManagedExports.GetActivationFactory(activatableClassId);
-                            """);
+                            """, isMultiline: true);
                     }
                     else if (info.Options.MergeReferencedActivationFactories)
                     {
@@ -198,7 +198,7 @@ public static nint GetActivationFactory(string activatableClassId)
                     {
                         return (nint)GetActivationFactory(activatableClassId.AsSpan());
                     }
-                    """);
+                    """, isMultiline: true);
             }
 
             // Emit a helper type with the logic for merging activaton factories, if needed
@@ -209,7 +209,7 @@ public static nint GetActivationFactory(string activatableClassId)
                     /// <summary>
                     /// Contains the logic for activating types from transitively referenced Windows Runtime components.
                     /// </summary>
-                    """);
+                    """, isMultiline: true);
                 writer.WriteGeneratedAttributes(nameof(AuthoringExportTypesGenerator), useFullyQualifiedTypeNames: false);
                 writer.WriteLine("file static unsafe class ReferencedManagedExports");
 
@@ -222,7 +222,7 @@ public static nint GetActivationFactory(string activatableClassId)
                         /// <param name="activatableClassId">The class identifier that is associated with an activatable runtime class.</param>
                         /// <returns>The resulting pointer to the activation factory that corresponds with the class specified by <paramref name="activatableClassId"/>.</returns>
                         public static void* GetActivationFactory(ReadOnlySpan<char> activatableClassId)
-                        """);
+                        """, isMultiline: true);
 
                     using (writer.WriteBlock())
                     {
@@ -239,7 +239,7 @@ public static nint GetActivationFactory(string activatableClassId)
                                 {
                                     return activationFactory;
                                 }
-                                """);
+                                """, isMultiline: true);
                         }
 
                         // No match across the referenced factories, we can't do anything else
@@ -290,7 +290,7 @@ namespace ABI.{info.AssemblyName.EscapeIdentifierName()};
                 /// <summary>
                 /// Contains the native exports for activating types from the current project in an authoring scenario.
                 /// </summary>
-                """);
+                """, isMultiline: true);
 
             // Emit the attributes to mark the code as generated, and to exclude it from code coverage as well. We also use a
             // file-scoped P/Invoke, so we don't take a dependency on private implementation detail types from 'WinRT.Runtime.dll'.
@@ -383,7 +383,7 @@ file static class WindowsRuntimeImports
                     [SupportedOSPlatform("windows6.2")]
                     public static extern char* WindowsGetStringRawBuffer(HSTRING @string, uint* length);
                 }
-                """);
+                """, isMultiline: true);
 
             context.AddSource("NativeExports.g.cs", writer.ToStringAndClear());
         }