Enable AL-LSP for Claude Code#652
Merged
Merged
Conversation
Mirrors the Copilot AL-LSP integration for Claude Code. Per-task isolation via Claude's --plugin-dir flag — no marketplace registration, no ENABLE_LSP_TOOL global state, no cross-run plugin leakage. - agent/shared/lsp.py: split build_lsp_config into build_copilot_lsp_config (writes .github/lsp.json, auto-discovered by Copilot CLI) and build_claude_lsp_plugin (writes a per-task plugin folder under <repo>/.claude/plugins/al-lsp/). Both share _resolve_symbol_paths / _build_lsp_args via a tiny _prepare_lsp helper. - agent/claude/agent.py: call build_claude_lsp_plugin, pass --plugin-dir to claude, record al_lsp_enabled in ExperimentConfiguration. - commands/run.py + commands/evaluate.py: add --al-lsp to the claude commands. - .github/workflows/claude-evaluation.yml: add al-lsp boolean input; Install AL Tool now triggers on al-mcp OR al-lsp; altool bumped to the version that supports launchlspserver; requeue payload propagates the flag. - tests/test_lsp_config.py: split into TestCopilotLspConfig and TestClaudeLspPlugin (22 tests total); the Claude class verifies plugin folder layout, Claude's distinct schema (no lspServers wrapper, extensionToLanguage instead of fileExtensions), and the priority order (compiler folder > artifact cache). - EXPERIMENT.md: surface al-lsp alongside al-mcp in the workflow inputs list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reviewer feedback: instead of two writers (.github/lsp.json for Copilot, .claude/plugins/al-lsp/ for Claude), use `--plugin-dir <path>` for both agents and ship a single plugin folder shape under <repo>/.bcbench/al-lsp-plugin/. Both CLIs look for the manifest at .claude-plugin/plugin.json, both accept --plugin-dir for ad-hoc per-session loading, so the only delta is the .lsp.json schema (Copilot wraps in 'lspServers' and uses 'fileExtensions'; Claude has no wrapper and uses 'extensionToLanguage'). That branch lives in a single ten-line _lsp_config_for() switch. - agent/shared/lsp.py: collapse build_copilot_lsp_config + build_claude_lsp_plugin into one build_al_lsp_plugin(entry, category, repo_path, agent_type, ...). 113 -> 95 LoC despite the new parameter. - agent/copilot/agent.py: drop the .github/lsp.json auto-discovery path; now passes --plugin-dir <path> like Claude. - agent/claude/agent.py: same call shape, same plugin folder. - tests/test_lsp_config.py: parametrize across both AgentType values so every shared behavior is verified for both agents in one class (10 shared tests x 2 agents + 2 schema-specific tests = 22). 227 -> ~150 LoC, same coverage. Live-verified: copilot --plugin-dir <plugin> now logs 'Loaded 1 LSP servers from 1 plugins' and reads our LSP config exactly the same way Claude would. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #651 (Copilot AL-LSP).
Adds per-task AL Language Server support for Claude Code, mirroring the Copilot integration. Uses Claude's
--plugin-dirflag to load a per-task plugin folder under<repo>/.claude/plugins/al-lsp/— no marketplace registration, noENABLE_LSP_TOOLglobal state, no cross-run plugin leakage.What's in the plugin folder
Claude's LSP schema differs from Copilot's: no
lspServerswrapper, andextensionToLanguageinstead offileExtensions. Symbol-path resolution and the artifact-cache fallback are shared with the Copilot path.Changes
agent/shared/lsp.py— split intobuild_copilot_lsp_config(unchanged) + newbuild_claude_lsp_plugin. Common_prepare_lsphelper.agent/claude/agent.py— acceptsal_lsp, calls the new builder, passes--plugin-dir, recordsal_lsp_enabledinExperimentConfiguration.commands/run.py+commands/evaluate.py— add--al-lspto claude commands..github/workflows/claude-evaluation.yml— addsal-lspboolean input;Install AL Toolstep now runs foral-mcp OR al-lsp; altool bumped to18.0.36.64936-beta; requeue payload propagates the flag.tests/test_lsp_config.py— restructured intoTestCopilotLspConfig(11) +TestClaudeLspPlugin(11). Claude class covers plugin layout, Claude-specific schema, container vs artifact-cache priority, error path.EXPERIMENT.md— surfacesal-lspalongsideal-mcp.Diff stat: 9 files, +237 / -68.
Verification
uv run pytest -q— 434/434 pass (was 423 onfeatures/al-lsp; +11 new Claude tests).uv run pre-commit run --all-files— clean.build_claude_lsp_plugincall.plugin.json+.lsp.jsonon disk match the expected Claude schema;altool launchlspserverargs resolved from the BC artifact cache.altool launchlspserveritself is already verified on Enable AL-LSP for evaluation #651 (24 LSP endpoints, fullinitializecapabilities response). The Claude side only changes how the LSP routing is consumed, not how altool serves it.Cannot live-test locally
Node/npm is not installed on the local Windows machine, so
claude --plugin-dir <path>cannot be exercised end-to-end here. CI runners install Claude vianpm install -g @anthropic-ai/claude-codeand will be the first live--al-lspvalidation. The plugin-folder layout matches the reference installer inBC-DeveloperExperience\eng\operations\Install-AlLspPlugin.ps1.