Add nrf52 power management for RAK3401#1984
Open
samschlegel wants to merge 1 commit intomeshcore-dev:devfrom
Open
Add nrf52 power management for RAK3401#1984samschlegel wants to merge 1 commit intomeshcore-dev:devfrom
samschlegel wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Author
|
Will get a verified commit pushed up shortly EDIT: Done! |
samschlegel
force-pushed
the
samschlegel/rak3401-power-management
branch
2 times, most recently
from
c9c33fb to
5646ae4
Compare
samschlegel
force-pushed
the
samschlegel/rak3401-power-management
branch
from
5646ae4 to
bfdbcd8
Compare
samschlegel
commented
Mar 10, 2026
| ;-D MESH_DEBUG=1 | ||
| build_src_filter = ${rak3401.build_src_filter} | ||
| +<helpers/ui/SSD1306Display.cpp> | ||
| +<../examples/simple_sensor> No newline at end of file |
Author
There was a problem hiding this comment.
can remove if desired. I have a pretty minimal VSCode setup and I'm pretty sure this is just the default so maybe work keeping?
samschlegel
commented
Mar 10, 2026
| } | ||
|
|
||
| #ifdef NRF52_POWER_MANAGEMENT | ||
| void RAK3401Board::initiateShutdown(uint8_t reason) { |
Author
There was a problem hiding this comment.
had to move the block for power_config to be defined before begin and figured it made sense to just move it all
weebl2000
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan