allow building from source#36
Conversation
Hywan
left a comment
There was a problem hiding this comment.
Oh neat! Thanks for the patch. Looks good so far. What does it need to get out of the draft?
|
i haven't tested it as an npm release yet, just from git |
|
It would be nice to have this as a default fallback when prebuilt binaries aren't available for the current platform/architecture, without |
richvdh
left a comment
There was a problem hiding this comment.
Sadly this seems to have been bitrotting for two years.
It looks like we should probably merge something similar to this, but I have a few thoughts:
- Rather than cluttering up the project directory with scripts, is there any reason we can't combine
download-lib.jsandpostinstall.jsinto a single file? - I'm minded to agree with @mqudsi that it would be nice to fall back to building from source automatically; however this isn't essential provided we document the necessary steps.
- Either way, the README needs an update.
@selfisekai if you're still out there, do you think you could give this an update?
Otherwise maybe someone else would like to pick up this work?
There was a problem hiding this comment.
This file needs a comment describing what it does.
closes #35