Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[flake8]
max-line-length = 120
ignore = W503,W504

[pycodestyle]
max_line_length = 120
1 change: 0 additions & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
include LICENSE
include README.rst
include CHANGES.md
include tox.ini
Expand Down
92 changes: 88 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,89 @@
[build-system]
requires = ["setuptools>=30.3.0",
"setuptools_scm",
"wheel"]
build-backend = 'setuptools.build_meta'
requires = [
"setuptools>=80",
"setuptools-scm[simple]>=8",
]
build-backend = "setuptools.build_meta"

[project]
name = "pytest-mpl"
authors = [
{ name = "Thomas Robitaille", email = "thomas.robitaille@gmail.com" },
]
license = "BSD-2-Clause"
license-files = [
"LICENSE",
]
classifiers = [
"Development Status :: 5 - Production/Stable",
"Framework :: Pytest",
"Intended Audience :: Developers",
"Topic :: Software Development :: Testing",
"Topic :: Scientific/Engineering :: Visualization",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Operating System :: OS Independent",
]
description = "pytest plugin to help with testing figures output from Matplotlib"
requires-python = ">=3.9"
dependencies = [
"pytest>=5.4.0",
"matplotlib>=3.3.3",
"packaging>=22.0.0",
"Jinja2>=2.10.2",
"Pillow>=8.1.1",
]
Comment on lines 29 to 35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still test against pytest 6.2, or at least should be if not for a tox config issue I just noticed. Python 3.9 was release 2020-10-05 and pytest 6.1.2 was released 2020-10-28. Would it make sense to change this to pytest>=6.2.0?

Similarly, we test against matplotlib 3.3 which had a release (3.3.3) 2020-11-12. Maybe we should set it to matplotlib>=3.3.3? I do realise 3.5 was the first Apple Silicon release — would setting it lower than that mess with uv's min deps resolution?

I'm hesitant to be too strict on pytest and matplotlib requirements since users are likely to want more control over those, and only drop support when it becomes a maintenance burden.

I'm happy with the other pins though — they seem to target the first Python 3.9 pure python wheels or Apple Silicon releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I've been doing basic testing on macos-amr64, so that limits how far back I can look.
I see you're fixing the root problem in #253 so I'll wait for that one to converge before I update pins here, but in principle I have no objection to lowering them, especially if they are actually tested !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rebased)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got the expected failure, lowered the bounds, rebased again. Now ready for review !

dynamic = [
"version",
]

[project.readme]
file = "README.rst"
content-type = "text/x-rst"

[project.urls]
Homepage = "https://github.com/matplotlib/pytest-mpl"

[project.entry-points.pytest11]
pytest_mpl = "pytest_mpl.plugin"

[project.optional-dependencies]
test = [
"pytest-cov>=6.0.0",
]
docs = [
"sphinx>=7.0.0",
"mpl_sphinx_theme>=3.9.0",
"sphinx_design>=0.6.0",
"matplotlib==3.9.*",
]

[tool.setuptools]
zip-safe = true
include-package-data = true

[tool.setuptools.packages.find]
namespaces = false

[tool.pytest.ini_options]
testpaths = [
"tests",
]
norecursedirs = [
"tests/subtests/subtest",
]
filterwarnings = [
"error",
"ignore:distutils Version classes are deprecated",
"ignore:the imp module is deprecated in favour of importlib",
"ignore:The NumPy module was reloaded",
]

[tool.isort]
balanced_wrapping = true
length_sort = false
length_sort_sections = [
"stdlib",
]
line_length = 100

68 changes: 0 additions & 68 deletions setup.cfg

This file was deleted.

5 changes: 0 additions & 5 deletions setup.py

This file was deleted.