Skip to content

Fix: missing 1 required positional argument: 'canvas' in Toolbar init #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fleming79 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix: missing 1 required positional argument: 'canvas' in Toolbar init #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ae3a55
Fix: missing 1 required positional argument: 'canvas' in Toolbar init
Jan 19, 2026
b57a331
Use super pattern in Canvas__init__ for better consistency.
Jan 20, 2026
3e920f2
DEMO fixed with jupyter-widgets/ipywidgets#4002
Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ jobs:
- name: Validate the labextension
run: jupyter labextension list 2>&1 | grep jupyter-matplotlib

- name: Install ipywidgets patched version (temporary)
run: pip install --force-reinstall https://github.com/fleming79/ipylab/releases/download/v2.0.9/ipywidgets-8.1.8-py3-none-any.whl

- name: Run pytest
run: pytest -v .

Expand Down
11 changes: 4 additions & 7 deletions ipympl/backend_nbagg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,8 @@ class Toolbar(DOMWidget, NavigationToolbar2WebAgg):

_current_action = Enum(values=['pan', 'zoom', ''], default_value='').tag(sync=True)

def __init__(self, canvas, *args, **kwargs):
DOMWidget.__init__(self, *args, **kwargs)
NavigationToolbar2WebAgg.__init__(self, canvas, *args, **kwargs)

def __init__(self, canvas, **kwargs):
super().__init__(canvas=canvas, **kwargs)
self.on_msg(self.canvas._handle_message)

def export(self):
Expand Down Expand Up @@ -240,9 +238,8 @@ class Canvas(DOMWidget, FigureCanvasWebAggCore):
# Static as it should be the same for all canvases
current_dpi_ratio = 1.0

def __init__(self, figure, *args, **kwargs):
DOMWidget.__init__(self, *args, **kwargs)
FigureCanvasWebAggCore.__init__(self, figure, *args, **kwargs)
def __init__(self, figure, **kwargs):
super().__init__(figure=figure, **kwargs)

self.on_msg(self._handle_message)

Expand Down
Loading