chartjs-chart-financial.js intergrate#72
Open
Jong-uk-Kim wants to merge 3 commits intomariusmuntean:masterfrom
Open
chartjs-chart-financial.js intergrate#72Jong-uk-Kim wants to merge 3 commits intomariusmuntean:masterfrom
Jong-uk-Kim wants to merge 3 commits intomariusmuntean:masterfrom
Conversation
Contributor
|
I don't have much time currently so I can't review it yet, sorry. Also I'm hesitating about upgrading chart.js since it will mean changes in other places as well; we'll have to think that through and also quickly (which is not this repos best quality) update all the C# code to work with the new chart.js release. It shouldn't be that big of a deal, I'm probably overdramatic but as I said, I don't have much time at the moment :/ |
Author
|
ok, i understand your concern, if you can be a time then merge this. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: chartjs-chart-financial.js interrte
implemented chartjs extension for financial.
※ Notes
ChartJs.min.js verserion updated to v2.9.3, because financial extension has dependency over v2.9.0.