Merged
Conversation
ChangelogFeatures
Bug fixes and improvements
Known issues
|
DzmitryFomchyn
approved these changes
Jul 7, 2023
dzinad
commented
Jul 10, 2023
| @@ -0,0 +1 @@ | |||
| - In case an app provides custom `Router` implementation to Nav SDK, the Nav SDK doesn't trigger `NavigationRouteAlternativesObserver` with online alternatives when current route is offline. | |||
Contributor
Author
There was a problem hiding this comment.
Is it really so? I thought it was more like "it's triggered, but much later". The alternatives mechanism is still working, right? we just won't trigger an alternative request as soon as the network is back.
Contributor
There was a problem hiding this comment.
@averkhaturau, can you please clarify consequences of using custom router for offline-online switch?
There was a problem hiding this comment.
NN knows which router is online only if it creates the routers itself. Providing a custom router makes this information unavailable, we don't know how to create an online router anymore. That's why the back online feature will not be available with a custom router
| // on implementation details in some cases like offline-online switch. | ||
| // Meanwhile platform SDK uses its own instance of native router for | ||
| // route requests | ||
| null |
Contributor
Author
There was a problem hiding this comment.
We also pass nativeRouter in recreate method. It should also be null.
Contributor
There was a problem hiding this comment.
nice one! fixing in a followup PR
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots or Gifs