Release snapshot workflow refactoring#6874
Merged
SevaZhukov merged 2 commits intomainfrom Jan 27, 2023
Merged
Conversation
ChangelogFeatures
val shielded = roadName.shieldedinto: val shielded = roadComponent.shield != null
Bug fixes and improvements
Known issues
|
dzinad
approved these changes
Jan 26, 2023
VysotskiVadim
approved these changes
Jan 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #6874 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5572 5572
=========================================
Files 782 782
Lines 30166 30166
Branches 3562 3562
=========================================
Hits 21926 21926
Misses 6814 6814
Partials 1426 1426 |
Author
|
Also, I've added the GitHub action which runs the |
dzinad
reviewed
Jan 27, 2023
| - release-snapshot: | ||
| requires: | ||
| - release-snapshot-start | ||
| - release-snapshot: |
Contributor
There was a problem hiding this comment.
Why do you have 2 jobs with the same name?
Author
There was a problem hiding this comment.
This is one job. We run it by:
- main and release branches
- approval in circle ci
- set PR label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure release-snapshot job confuses the team when it runs on branches and PRs without the
publish-snapshotlabel.I propose a way like for the mobile-metrics-benchmarks job. If you want to publish a snapshot just approve the
release-snapshot-startjob, and it will start therelease-snapshot-1job (with postfix 1 because we use this job for the main and release branches too). Therelease-snapshot-2job will be started without approvals for the main and release branches.@RingerJK @Zayankovsky