CI: enable snapshot repo for snapshot releases#6870
Conversation
ChangelogFeatures
val shielded = roadName.shieldedinto: val shielded = roadComponent.shield != null
Bug fixes and improvements
Known issues
|
Codecov Report
@@ Coverage Diff @@
## main #6870 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5572 5572
=========================================
Files 782 782
Lines 30166 30166
Branches 3562 3562
=========================================
Hits 21926 21926
Misses 6814 6814
Partials 1426 1426 |
|
@RingerJK since using a snapshot shouldn't be allowed to be merged, this means that a snapshot with a snapshot can only be released from a non-protected/non-main branch. In this case, couldn't you enable snapshot builds directly in the branch and revert it before merging? |
@LukasPaczos I thought about it, but it seems it's not so straightforward: enabling a branch snapshot means we need an additional check that prevents merging this branch into the production branch ( |
This should be rejected during a review process, as with any other change. I don't think adding the flag proposed in this PR makes that safer in any way. |
|
actually, cannot fully agree: the PR cannot be merged as |
|
@LukasPaczos , do you worry that snapshot dependency could be accidentally used during normal release if this PR will be merged? |
LukasPaczos
left a comment
There was a problem hiding this comment.
I don't have too strong of an opinion. The flag just looks a little bit redundant since you need to change one locally anyway, but if you see this improving some workflow, let's merge.
Description
CI: enable snapshot repo for snapshot releases
Ideally, the above jobs should be allowed but forbidden to merge.