Conversation
kmadsen
added
the
Android Auto
Codecov Report
@@ Coverage Diff @@
## main #6492 +/- ##
=========================================
Coverage 70.03% 70.03%
Complexity 4830 4830
=========================================
Files 708 708
Lines 27867 27867
Branches 3278 3278
=========================================
Hits 19518 19518
Misses 7068 7068
Partials 1281 1281 |
kmadsen
force-pushed
the
km-remove-MapboxCarApp
branch
from
a57699f to
a1c9f36
Compare
Contributor
Author
|
@dzinad 🤔 changelog is failing again EDIT: Sorry there is perfect error messaging telling me what's wrong |
kmadsen
commented
Oct 19, 2022
|
|
||
| init { | ||
| logAndroidAuto("MainCarSession constructor") | ||
| MapboxCarApp.setup() |
Contributor
Author
There was a problem hiding this comment.
This is the reason for this pull request. It is hard to know that you need to call this and we can finally delete it 🎉
kmadsen
force-pushed
the
km-remove-MapboxCarApp
branch
from
a1c9f36 to
e328709
Compare
Zayankovsky
reviewed
Oct 19, 2022
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/location/CarLocationProvider.kt
Show resolved
Hide resolved
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/location/CarLocationProvider.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-remove-MapboxCarApp
branch
2 times, most recently
from
e52fecb to
b644c74
Compare
Zayankovsky
approved these changes
Oct 19, 2022
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/location/CarLocationProvider.kt
Outdated
Show resolved
Hide resolved
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/location/CarLocationProvider.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-remove-MapboxCarApp
branch
from
b644c74 to
467cb62
Compare
kmadsen
commented
Oct 19, 2022
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/location/CarLocationProvider.kt
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-remove-MapboxCarApp
branch
from
073b9ee to
dbd8f12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small version of this #6420. But that will require an sdk release, and we may have reasons to have a
CarLocationProviderwhen adopting android auto vehicle sensors.In order to delete
MapboxCarAppwe also need a way to share an instance of a location provider. The update to a core-sdk implementation may be a better long term approach but an androidauto solution is needed for the short term.