fix(i18n): localize toast accessibility labels - #9588
Open
bulunote wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughToast accessibility labels now use existing i18n translations. The Propel package declares ChangesToast accessibility localization
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bulunote
marked this pull request as ready for review
August 12, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The shared Propel toast component does not provide locale-aware accessible names for its notification viewport or close control. As a result, assistive technology can receive no explicit label or an English library default even when the active Plane language is not English.
This PR localizes those hidden accessibility labels by:
@plane/i18nas an explicit Propel dependency;notificationstranslation key;closetranslation key; andNo new translation keys are introduced. The existing keys are already translated across all supported locales, including
通知/关闭for Simplified Chinese and通知/關閉for Traditional Chinese.This PR intentionally covers only toast accessibility text. Other visible localization surfaces are being kept in separate reviewable changes.
Type of Change
Screenshots and Media (if applicable)
There is no visual change. The resulting accessible markup uses the active locale:
Test Scenarios
node --test --experimental-strip-types packages/i18n/scripts/__tests__/toast-accessibility-localization.test.tspnpm turbo run build --filter=@plane/propel...tsc --noEmit -p packages/propel/tsconfig.json--deny-warningspnpm --filter @plane/i18n check:syncgit diff --checkReferences
Summary by CodeRabbit
Accessibility
Tests