Skip to content

[bug]: text highlighter was drawn multiple times when color change#837

Closed
HM-Suiji wants to merge 1 commit intomagicuidesign:mainfrom
HM-Suiji:main
Closed

[bug]: text highlighter was drawn multiple times when color change#837
HM-Suiji wants to merge 1 commit intomagicuidesign:mainfrom
HM-Suiji:main

Conversation

@HM-Suiji
Copy link
Copy Markdown

@HM-Suiji HM-Suiji commented Nov 8, 2025

Fixes #836

I use 2 use effect to avoid the trouble, it can work successfully.

Tips: I don't change the json, llms, mdx, and so on, but I change the source code only, so you need to update them.

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 8, 2025

@HM-Suiji is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo Yeom-JinHo self-requested a review March 1, 2026 02:18
@Yeom-JinHo Yeom-JinHo added bug Something isn't working and removed bug Something isn't working labels Mar 1, 2026
@Yeom-JinHo
Copy link
Copy Markdown
Member

@HM-Suiji
Hi! Thanks so much for the contribution and for taking the time to open this PR.

Could you please submit this from a branch other than main (for example, a feature branch) and update the PR source branch?

Really appreciate your help!

@Yeom-JinHo
Copy link
Copy Markdown
Member

I think annotate() creates the annotation, but it never calls show() initially.
So if there’s no resize or color change, the highlight may never appear.

@Yeom-JinHo
Copy link
Copy Markdown
Member

@HM-Suiji

Closing for now due to inactivity.

Feel free to reopen or submit a new PR once it’s ready!

@Yeom-JinHo Yeom-JinHo closed this Mar 19, 2026
@HM-Suiji
Copy link
Copy Markdown
Author

I'm so sorry. As I'm not very familiar with the Git workflow, I accidentally made a pull request directly into the main branch. However, the problem was resolved and the outcome was good.

@Yeom-JinHo
Copy link
Copy Markdown
Member

@HM-Suiji
No worries at all.
These things happen, and we really appreciate your contribution. Glad to hear everything worked out well in the end.
Tysm again, and feel free to open another PR anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: text highlighter was drawn multiple times when color change

2 participants