feat: Remove xcode projects from all kits#646
feat: Remove xcode projects from all kits#646denischilik wants to merge 9 commits intoworkstation/9.0-Releasefrom
Conversation
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604} |
37844c6 to
f9fa309
Compare
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Looks good in general. Basically we're just relying on the example app builds to detect build issues.
There's a one thing I'd appreciate if we could add.
Somewhere in the README, CONTRIBUTING, etc. should detail how to build and test kits locally. I'm also curious if the matrix.json still needs scheme fields?
jamesnrokt
left a comment
There was a problem hiding this comment.
Before approving this I'd need to see how you're replacing the xcframework logic
Just to clarify — which part of the xcframework logic are you referring to? Kits have not been distributed as binaries, so I want to make sure I understand what you expect to be replaced. |
@BrandonStalnaker The way I understood it is that we will be building and testing directly from the Package.swift and the schemes would still be needed. |
We don't need schemas in matrix.json because we can directly get them from Package.swift of each kit. |
In this PR you removed the XCFramework creation from What's the plan to reinstate creation of XCFrameworks for partners that don't want the compilation overhead of SPM or prefer working with XCFrameworks |
We are not planning to reinstate XCFramework generation as part of the standard release workflow. This PR removes the Xcode projects and related CI jobs because the team decided not to support distributing kits as .xcframework binaries. Per the kit simplification design, the default partner-facing distribution for iOS is via SPM and CocoaPods, and XCFramework generation is considered unnecessary for kits. If a partner specifically needs XCFrameworks, we can provide them on request rather than building and attaching them to every GitHub release. |
|
Decided to close it. |
Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)