An attempt to subdivide each edge in 3#11
Draft
creaktive wants to merge 2 commits intolooeee:mainfrom
Draft
Conversation
creaktive
commented
Aug 7, 2022
| console.time("Generate Tiling"); | ||
| const tiling = new RegularHyperbolicTesselation(this.spec).generateTiling( | ||
| false | ||
| true |
creaktive
commented
Aug 7, 2022
src/utilities/createGeometries.js
Outdated
| // numDivisions = numDivisions || ( arc.arcLength > 0.001 ) | ||
| // ? 2 * Math.ceil( arc.arcLength ) // currently always = 2 | ||
| // : 1; | ||
| numDivisions = 3; |
Contributor
Author
There was a problem hiding this comment.
Force all edges to be subdivided in 3
creaktive
commented
Aug 7, 2022
| const endPoint = subdividedEdges[1][i]; | ||
| // this.subdivideInteriorArc( startPoint, endPoint, i ); | ||
| const newPoints = subdivideLine( startPoint, endPoint, i ); | ||
| const newPoints = subdivideLine( startPoint, endPoint, numDivisions, i ); |
Contributor
Author
There was a problem hiding this comment.
Typo here? Was not matching the prototype of subdivideLine()
creaktive
commented
Aug 7, 2022
| } | ||
|
|
||
| if ( polygon.materialIndex === 0 ) { | ||
| addPositionsAndUvs( positionsA, positionAIndex, uvsA, uvAIndex ); |
Contributor
Author
There was a problem hiding this comment.
Cleanup, so that "Too many divisions!!" error is not thrown
creaktive
commented
Aug 7, 2022
Contributor
Author
creaktive
left a comment
creaktive
left a comment
There was a problem hiding this comment.
Without these changes, numDivisions set to >= 3 causes errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step into the right direction, however it is still not working. Edge still has 3 points instead of 4, however the point on the edge is where it should be, if it had 4: