Sending Request terminated status when Call is cancelled#409
Open
alastor09 wants to merge 1 commit intolivekit:mainfrom
Open
Sending Request terminated status when Call is cancelled#409alastor09 wants to merge 1 commit intolivekit:mainfrom
alastor09 wants to merge 1 commit intolivekit:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 65.25% 62.92% -2.33%
==========================================
Files 51 32 -19
Lines 6588 6776 +188
==========================================
- Hits 4299 4264 -35
- Misses 1915 2129 +214
- Partials 374 383 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alastor09
force-pushed
the
fix/callCancelled
branch
from
88ade09 to
af6e566
Compare
alastor09
force-pushed
the
fix/callCancelled
branch
2 times, most recently
from
a2a75f3 to
aaeee9f
Compare
alastor09
force-pushed
the
fix/callCancelled
branch
from
aaeee9f to
bd4ac71
Compare
alastor09
force-pushed
the
fix/callCancelled
branch
from
bd4ac71 to
5c747cf
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed that LiveKit SIP sometimes returned SIP status 486 Busy Here when a SIP caller canceled the call. This behavior was inconsistent with expected SIP cancellation handling.
Removed duplicate cancellation handling during ringing:
Cancellation logic was previously executed in multiple places — both during ringing and WaitMedia.
This caused incorrect status (like 486 Busy Here) to be returned when the call was simply canceled by the caller.
Updated closeWithCancelled() to consistently mark the call as CallCancelled.
Based on this status, the SIP response now correctly returns 487 Request Terminated, as per SIP spec for cancellations.
Updated attributes to reflect that as well